From: Richard Weinberger <richard@sigma-star.at>
To: Bogdan Harjoc <harjoc@gmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: Handle eraseblocks containing the bad-block table in UBI
Date: Sat, 13 Jan 2018 15:17:34 +0100 [thread overview]
Message-ID: <5069949.lP7kaqOdCT@blindfold> (raw)
In-Reply-To: <CAF4+tmpcv-zTJKj++AwRfU=vf3OjhK2_jDvJS-KyNX3mZW_uNg@mail.gmail.com>
Am Samstag, 13. Januar 2018, 13:44:54 CET schrieb Bogdan Harjoc:
> On Fri, Jan 12, 2018 at 10:52 PM, Richard Weinberger
>
> <richard.weinberger@gmail.com> wrote:
> > Usually blocks containing the BBT are also marked as bad to avoid the
> > problem you're facing.
> > So, yes UBI should not see these PEBs because they should look like bad
> > blocks.
> >
> > Is this a kernel with vendor hackery?
>
> It is, at least the nand probing code adds its own nand_bbt_descr
> structs. Since the issue goes away by adding an
>
> if (ec_hdr->magic == 'Bbt0' or '1bbT')
> treat_it_as_bad_block()
>
> in ubi_io_read_ec_hdr(), I will see where the bad-block status for the
> bbt PEBs gets lost.
UBI is the wrong layer to address this.
Please make sure that these blocks are handled in the NAND core.
BBT_BLOCK_RESERVED is the flag you need for them.
Thanks,
//richard
--
sigma star gmbh - Eduard-Bodem-Gasse 6 - 6020 Innsbruck - Austria
ATU66964118 - FN 374287y
prev parent reply other threads:[~2018-01-13 14:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 15:48 Handle eraseblocks containing the bad-block table in UBI Bogdan Harjoc
2018-01-12 20:52 ` Richard Weinberger
2018-01-13 12:46 ` Bogdan Harjoc
[not found] ` <CAF4+tmpcv-zTJKj++AwRfU=vf3OjhK2_jDvJS-KyNX3mZW_uNg@mail.gmail.com>
2018-01-13 14:17 ` Richard Weinberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5069949.lP7kaqOdCT@blindfold \
--to=richard@sigma-star.at \
--cc=harjoc@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.