From: Anthony PERARD <anthony.perard@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
Xen Devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 1/2] libxl_json: Use libxl alloc function
Date: Mon, 1 Oct 2012 15:04:05 +0100 [thread overview]
Message-ID: <5069A2D5.9010205@citrix.com> (raw)
In-Reply-To: <20581.56505.946303.990641@mariner.uk.xensource.com>
On 09/28/2012 06:22 PM, Ian Jackson wrote:
> Anthony PERARD writes ("[Xen-devel] [PATCH 1/2] libxl_json: Use libxl alloc function"):
>> This patch makes use of the libxl allocation API and removes the check for
>> allocation failure.
>>
>> This patch also assume that flexarray does not need to be freed as it will be
>> gc'd in the next patch.
>
> Is this really the right way to structure this series ? It seems that
> after applying only the first, the code has a memory leak.
Yes, there is a memory leak if only this patch is applied. I'll find a
better way to structure this patch series.
--
Anthony PERARD
next prev parent reply other threads:[~2012-10-01 14:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 13:31 [PATCH 0/2] Cleanup: flexarray taking gc Anthony PERARD
2012-09-26 13:31 ` [PATCH 1/2] libxl_json: Use libxl alloc function Anthony PERARD
2012-09-28 17:22 ` Ian Jackson
2012-10-01 14:04 ` Anthony PERARD [this message]
2012-09-26 13:31 ` [PATCH 2/2] libxl: Have flexarray using the GC Anthony PERARD
2012-09-28 17:27 ` Ian Jackson
2012-10-01 14:15 ` Anthony PERARD
2012-10-01 14:17 ` Ian Jackson
2012-10-01 14:23 ` Anthony PERARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5069A2D5.9010205@citrix.com \
--to=anthony.perard@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.