From: Len Brown <lenb@kernel.org>
To: "Ortiz, Lance E" <lance.oritz@hp.com>
Cc: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
"rob@landley.net" <rob@landley.net>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] ACPI: Add new sysfs interface to export device description
Date: Tue, 02 Oct 2012 00:14:45 -0400 [thread overview]
Message-ID: <506A6A35.4060500@kernel.org> (raw)
In-Reply-To: <A961433CDFF2F640A2866803152E61F950D1B50A@G9W0753.americas.hpqcorp.net>
>
> To address your comment, I was trying to differentiate between the existence of the _STR method and the failure to evaluate it.
> If an STR method exists, we create the sysfs file. If it fails to
evaluate, we will see "No Description" when we read the file.
> This would indicate that something is wrong as opposed to the system not having an _STR.
> If you feel that this is unnecessary, or should be done differently let me know.
This patch looks useful, and I this does seem like a logical place
to export this information.
however, I'd think that an empty attribute instead of "No description"
is sufficient to cover the case of _STR existing, but for some reason
failing to evaluate.
thanks,
Len Brown, Intel Open Source Technology Center
prev parent reply other threads:[~2012-10-02 4:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 16:28 [PATCH] ACPI: Add new sysfs interface to export device description Lance Ortiz
2012-09-19 5:45 ` Yasuaki Ishimatsu
2012-09-19 5:45 ` Yasuaki Ishimatsu
2012-09-19 14:27 ` Ortiz, Lance E
2012-10-02 4:14 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506A6A35.4060500@kernel.org \
--to=lenb@kernel.org \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=lance.oritz@hp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.