Re: Problem using S3C2416's HSSPI

[Sylwester Nawrocki <s.nawrocki@samsung.com>]

On 10/02/2012 01:47 AM, Heiko Stübner wrote:
>> diff --git a/arch/arm/mach-s3c24xx/common-s3c2443.c
>> b/arch/arm/mach-s3c24xx/common-s3c2443.c index aeeb2be..aeb4a24 100644
>> --- a/arch/arm/mach-s3c24xx/common-s3c2443.c
>> +++ b/arch/arm/mach-s3c24xx/common-s3c2443.c
>> @@ -559,7 +559,7 @@ static struct clk hsmmc1_clk = {
>>
>>  static struct clk hsspi_clk = {
>>         .name           = "spi",
>> -       .devname        = "s3c64xx-spi.0",
>> +       .devname        = "s3c2443-spi.0",
>>         .parent         = &clk_p,
>>         .enable         = s3c2443_clkcon_enable_p,
>>         .ctrlbit        = S3C2443_PCLKCON_HSSPI,
>> @@ -633,7 +633,7 @@ static struct clk_lookup s3c2443_clk_lookup[] = {
>>         CLKDEV_INIT(NULL, "clk_uart_baud2", &clk_p),
>>         CLKDEV_INIT(NULL, "clk_uart_baud3", &clk_esys_uart.clk),
>>         CLKDEV_INIT("s3c-sdhci.1", "mmc_busclk.0", &hsmmc1_clk),
>> -       CLKDEV_INIT("s3c64xx-spi.0", "spi_busclk0", &hsspi_clk),
>> +       CLKDEV_INIT("s3c2443-spi.0", "spi_busclk0", &hsspi_clk),
>>  };
> 
> ahaa ... that's the cause. As far as I was able to determine, in the patchset 
> only the clocks were renamed and the different device names introduced.
> 
> The spi devices did not get a function to set the name, like for the rtc, adc 
> and nand. The devices are named s3c6410-spi by default, so it seems only the 
> s3c64xx machines should have a working spi currently.

That reminds me that I have some patches that set the SPI device names and
I have been using those for non-dt exynos platform. Yes, it looks like we
need a generic function for all Samsung machines that would override SPI
device names on all except mach-s3c64xx.

> I'm working on a patch to fix this for all Samsung arches.

OK. I have something like this too. Anyway it seems SPI is now broken on
all non-dt machines except s3c64xx in kernel 3.6. Perhaps these patches
should be also sent now to stable@vger.kernel.org.

Regards,
Sylwester


-- 
Sylwester Nawrocki
Samsung Poland R&D Center