From: Jeff Garzik <jgarzik@pobox.com>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Suresh Siddha <suresh.b.siddha@intel.com>,
Yinghai Lu <yinghai@kernel.org>,
Matthew Wilcox <willy@linux.intel.com>,
x86@kernel.org, linux-pci@vger.kernel.org,
linux-ide@vger.kernel.org
Subject: Re: [PATCH v3 -tip 5/5] AHCI: Support multiple MSIs
Date: Tue, 02 Oct 2012 12:45:26 -0400 [thread overview]
Message-ID: <506B1A26.2060609@pobox.com> (raw)
In-Reply-To: <20121002164220.GB2258@dhcp-26-207.brq.redhat.com>
On 10/02/2012 12:42 PM, Alexander Gordeev wrote:
> On Tue, Oct 02, 2012 at 07:09:29AM +0200, Ingo Molnar wrote:
>>> +irqreturn_t ahci_hw_interrupt(int irq, void *dev_instance)
>>> +{
>>> + struct ata_port *ap_this = dev_instance;
>>> + struct ahci_port_priv *pp = ap_this->private_data;
>>> + struct ata_host *host = ap_this->host;
>>> + struct ahci_host_priv *hpriv = host->private_data;
>>> + void __iomem *mmio = hpriv->mmio;
>>> + unsigned int i;
>>> + u32 irq_stat, irq_masked;
>>> +
>>> + VPRINTK("ENTER\n");
>>
>> Is this per IRQ handler execution debugging code still needed?
>> Same for the other VPRINTK() lines in this patch.
>
> These VPRINKs are only to make new handlers look like ahci_interrupt()
> which did not change. I believe, if they need to go it is better to
> remove them altogether, with a separate followup patch.
Definitely followup patch material + discussion :)
For the moment, the above is consistent with existing code, and by
default compiled out, as one would expect.
Jeff
next prev parent reply other threads:[~2012-10-02 16:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-01 8:08 [PATCH v3 -tip 0/5] x86, MSI, AHCI: Support multiple MSIs Alexander Gordeev
2012-10-01 8:09 ` [PATCH v3 -tip 1/5] x86, MSI: Support multiple MSIs in presense of IRQ remapping Alexander Gordeev
2012-10-02 4:55 ` Ingo Molnar
2012-10-02 11:06 ` Alexander Gordeev
2012-10-02 11:25 ` Ingo Molnar
2012-10-04 7:54 ` Alexander Gordeev
2012-10-04 9:17 ` Ingo Molnar
2012-10-01 8:10 ` [PATCH v3 -tip 2/5] x86, MSI: Allocate as many multiple IRQs as requested Alexander Gordeev
2012-10-02 4:58 ` Ingo Molnar
2012-10-01 8:11 ` [PATCH v3 -tip 3/5] x86, MSI: Minor readability fixes Alexander Gordeev
2012-10-02 4:57 ` Ingo Molnar
2012-10-01 8:12 ` [PATCH v3 -tip 4/5] PCI, MSI: Enable multiple MSIs with pci_enable_msi_block_auto() Alexander Gordeev
2012-10-01 8:13 ` [PATCH v3 -tip 5/5] AHCI: Support multiple MSIs Alexander Gordeev
2012-10-02 3:04 ` Jeff Garzik
2012-10-02 4:21 ` Bjorn Helgaas
2012-10-02 4:48 ` Jeff Garzik
2012-10-02 5:09 ` Ingo Molnar
2012-10-02 16:42 ` Alexander Gordeev
2012-10-02 16:45 ` Jeff Garzik [this message]
2012-10-04 14:35 ` Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506B1A26.2060609@pobox.com \
--to=jgarzik@pobox.com \
--cc=agordeev@redhat.com \
--cc=bhelgaas@google.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=willy@linux.intel.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.