From: Saul Wold <sgw@linux.intel.com>
To: Phil Blundell <philb@gnu.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] sstate: Add detail to shared area warning
Date: Tue, 02 Oct 2012 15:06:10 -0700 [thread overview]
Message-ID: <506B6552.3040503@linux.intel.com> (raw)
In-Reply-To: <1349215253.4422.79.camel@x121e.pbcl.net>
On 10/02/2012 03:00 PM, Phil Blundell wrote:
> On Tue, 2012-10-02 at 15:00 -0700, Saul Wold wrote:
>> - bb.warn("The recipe is trying to install files into a shared area when those files already exist. Those files are:\n %s" % "\n ".join(match))
>> + bb.warn("The %s recipe is trying to install files into a shared area when those files already exist (please fix %s). Those files are:\n %s" % (d.getVar('PN', True), d.getVar('FILE', True), "\n ".join(match)))
>
> That seems potentially misleading: the file that needs fixing isn't
> necessarily the one that triggers this warning. What would be ideal
> would be to have it output the names of all recipes that have tried to
> stage the files in question so that the user can make an informed
> decision about which one ought to be putting them there.
>
True enough, but we don't have that information at that time, but it
gives more information than we had before, as to which recipe was adding
the files, I guess if I change the wording to something like
"verify" or "check"?
Sau!
> p.
>
>
>
>
next prev parent reply other threads:[~2012-10-02 22:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 22:00 [PATCH] sstate: Add detail to shared area warning Saul Wold
2012-10-02 22:00 ` Phil Blundell
2012-10-02 22:06 ` Saul Wold [this message]
2012-10-02 22:05 ` Phil Blundell
2012-10-02 22:11 ` Martin Jansa
2012-10-02 22:22 ` Richard Purdie
2012-10-03 1:00 ` McClintock Matthew-B29882
2012-10-02 22:20 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506B6552.3040503@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=philb@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.