From: Michal Marek <mmarek@suse.cz>
To: Jean Delvare <jdelvare@suse.de>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Bernhard Walle <bernhard@bwalle.de>,
Ralf Baechle <ralf@linux-mips.org>,
akpm@linux-foundation.org
Subject: Re: [PATCH v3] kbuild: Fix gcc -x syntax
Date: Wed, 03 Oct 2012 11:17:47 +0200 [thread overview]
Message-ID: <506C02BB.20606@suse.cz> (raw)
In-Reply-To: <1349188956.4441.12.camel@amber.site>
On 2.10.2012 16:42, Jean Delvare wrote:
> The correct syntax for gcc -x is "gcc -x assembler", not
> "gcc -xassembler". Even though the latter happens to work, the former
> is what is documented in the manual page and thus what gcc wrappers
> such as icecream do expect.
>
> This isn't a cosmetic change. The missing space prevents icecream from
> recognizing compilation tasks it can't handle, leading to silent kernel
> miscompilations.
>
> Besides me, credits go to Michael Matz and Dirk Mueller for
> investigating the miscompilation issue and tracking it down to this
> incorrect -x parameter syntax.
Applied to kbuild.git#rc-fixes. Thanks to everyone involved.
Michal
prev parent reply other threads:[~2012-10-03 9:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 14:42 [PATCH v3] kbuild: Fix gcc -x syntax Jean Delvare
2012-10-03 9:17 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506C02BB.20606@suse.cz \
--to=mmarek@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=bernhard@bwalle.de \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.