From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out-070.synserver.de ([212.40.185.70]:1074 "EHLO smtp-out-070.synserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753788Ab2JCJRv (ORCPT ); Wed, 3 Oct 2012 05:17:51 -0400 Message-ID: <506C02F3.2050506@metafoo.de> Date: Wed, 03 Oct 2012 11:18:43 +0200 From: Lars-Peter Clausen MIME-Version: 1.0 To: Peter Meerwald CC: linux-iio@vger.kernel.org, 21cnbao@gmail.com Subject: Re: [PATCH] staging iio: use iio_trigger_generic_data_rdy_poll() in accel/adis16209 driver References: <1348877262-8593-1-git-send-email-pmeerw@pmeerw.net> In-Reply-To: <1348877262-8593-1-git-send-email-pmeerw@pmeerw.net> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 09/29/2012 02:07 AM, Peter Meerwald wrote: > Signed-off-by: Peter Meerwald > Cc: 21cnbao@gmail.com Looks good, Acked-by: Lars-Peter Clausen > --- > drivers/staging/iio/accel/adis16209_trigger.c | 11 +---------- > drivers/staging/iio/accel/adis16240_trigger.c | 11 +---------- > 2 files changed, 2 insertions(+), 20 deletions(-) > > diff --git a/drivers/staging/iio/accel/adis16209_trigger.c b/drivers/staging/iio/accel/adis16209_trigger.c > index 2ad93dc..1122803 100644 > --- a/drivers/staging/iio/accel/adis16209_trigger.c > +++ b/drivers/staging/iio/accel/adis16209_trigger.c > @@ -8,15 +8,6 @@ > #include "adis16209.h" > > /** > - * adis16209_data_rdy_trig_poll() the event handler for the data rdy trig > - **/ > -static irqreturn_t adis16209_data_rdy_trig_poll(int irq, void *trig) > -{ > - iio_trigger_poll(trig, iio_get_time_ns()); > - return IRQ_HANDLED; > -} > - > -/** > * adis16209_data_rdy_trigger_set_state() set datardy interrupt state > **/ > static int adis16209_data_rdy_trigger_set_state(struct iio_trigger *trig, > @@ -45,7 +36,7 @@ int adis16209_probe_trigger(struct iio_dev *indio_dev) > } > > ret = request_irq(st->us->irq, > - adis16209_data_rdy_trig_poll, > + iio_trigger_generic_data_rdy_poll, > IRQF_TRIGGER_RISING, > "adis16209", > st->trig); > diff --git a/drivers/staging/iio/accel/adis16240_trigger.c b/drivers/staging/iio/accel/adis16240_trigger.c > index fa90a22..f3caf09 100644 > --- a/drivers/staging/iio/accel/adis16240_trigger.c > +++ b/drivers/staging/iio/accel/adis16240_trigger.c > @@ -8,15 +8,6 @@ > #include "adis16240.h" > > /** > - * adis16240_data_rdy_trig_poll() the event handler for the data rdy trig > - **/ > -static irqreturn_t adis16240_data_rdy_trig_poll(int irq, void *trig) > -{ > - iio_trigger_poll(trig, iio_get_time_ns()); > - return IRQ_HANDLED; > -} > - > -/** > * adis16240_data_rdy_trigger_set_state() set datardy interrupt state > **/ > static int adis16240_data_rdy_trigger_set_state(struct iio_trigger *trig, > @@ -45,7 +36,7 @@ int adis16240_probe_trigger(struct iio_dev *indio_dev) > } > > ret = request_irq(st->us->irq, > - adis16240_data_rdy_trig_poll, > + iio_trigger_generic_data_rdy_poll, > IRQF_TRIGGER_RISING, > "adis16240", > st->trig);