From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJTXo-0005ED-0U for qemu-devel@nongnu.org; Wed, 03 Oct 2012 14:19:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJTXm-00024W-Ul for qemu-devel@nongnu.org; Wed, 03 Oct 2012 14:19:39 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:37400) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJTXm-00024M-OH for qemu-devel@nongnu.org; Wed, 03 Oct 2012 14:19:38 -0400 Message-ID: <506C81B8.908@weilnetz.de> Date: Wed, 03 Oct 2012 20:19:36 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1349287498-10475-1-git-send-email-sandmann@cs.au.dk> In-Reply-To: <1349287498-10475-1-git-send-email-sandmann@cs.au.dk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Fix compilation on GCC 4.5 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?U8O4cmVuIFNhbmRtYW5u?= Cc: qemu-devel@nongnu.org Am 03.10.2012 20:04, schrieb S=C3=B8ren Sandmann: > From: S=C3=B8ren Sandmann Pedersen > > Apparently GCC 4.5 still warns about "value computed not used" even > with __attribute__((unused)). Fix this by only doing the compile time > check on gcc> 4.5. > > Signed-off-by: Soren Sandmann > --- > > I need this patch to get qemu to compile with GCC 4.5, but I'm not > sure if 4.5 is the right compiler version to check against. > > osdep.h | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/osdep.h b/osdep.h > index cb213e0..df89552 100644 > --- a/osdep.h > +++ b/osdep.h > @@ -41,8 +41,9 @@ typedef signed int int_fast16_t; > #endif > > /* Convert from a base type to a parent type, with compile time check= ing. */ > -#ifdef __GNUC__ > -#define DO_UPCAST(type, field, dev) ( __extension__ ( { \ > +#if defined (__GNUC__)&& \ > + (__GNUC__> 4 || (__GNUC__ =3D=3D 4&& __GNUC_MINOR__> 5)) > +#define DO_UPCAST(type, field, dev) ( __extension__ ( { \ > char __attribute__((unused)) offset_must_be_zero[ \ > -offsetof(type, field)]; \ > container_of(dev, type, field);})) Hello, I don't see any warnings with gcc Debian 4.4.5-8. Could you please provide more information on your environment and the warnings which you get? Here is a macro which simplifies the version check: #if QEMU_GNUC_PREREQ(4, 6) Regards Stefan Weil