All of lore.kernel.org
 help / color / mirror / Atom feed
From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: "Hefty, Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Steve Wise
	<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>,
	"Marciniszyn,
	Mike" <mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: Problem running rping over Intel adapters
Date: Wed, 03 Oct 2012 18:05:47 -0400	[thread overview]
Message-ID: <506CB6BB.10102@redhat.com> (raw)
In-Reply-To: <1828884A29C6694DAF28B7E6B8A8237346A98E8E-Q3cL8pyY+6ukrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1427 bytes --]

On 10/3/2012 6:02 PM, Hefty, Sean wrote:
>>>> 1) rping, on the client side, clears the conn_params for the 
>>>> newly to be attempted connection, then sets:
>>>> 
>>>> conn_param.responder_resources = 1; conn_param.initiator_depth 
>>>> = 1; conn_param.retry_count = 10;
>>> 
>>> 
>>>> 2) the qib driver enforces a maximum of 7 for retry_count.  I 
>>>> don't see anything in the spec that specifies a maximum for 
>>>> this entry, and in particular I know it doesn't call out for 7 
>>>> to mean infinite retries like it does for rnr_retry_count.
>>> 
>>> On IB, retry count is a 3-bit value.  See the CM REQ message.
>>> 
>>> The kernel rdma cm should probably check for a valid value and 
>>> reduce it
>> accordingly.
>> 
>> Then it's also fair to say that right now rping passes a known 
>> invalid value and needs fixed ;-)
> 
> For IB, but I wasn't sure about iWarp.  It doesn't look like it's 
> used there though.

I would hope it's not used on iWARP....it's running over it's
own link layer where this is neither defined nor applicable.

> If not, I'll apply a patch to rping, plus submit a fix for the
> kernel to validate the value.




-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD
	      http://people.redhat.com/dledford

Infiniband specific RPMs available at
	      http://people.redhat.com/dledford/Infiniband


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 895 bytes --]

  parent reply	other threads:[~2012-10-03 22:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-03 21:40 Problem running rping over Intel adapters Doug Ledford
     [not found] ` <506CB0E9.90201-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-10-03 21:50   ` Hefty, Sean
     [not found]     ` <1828884A29C6694DAF28B7E6B8A8237346A98E58-Q3cL8pyY+6ukrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2012-10-03 21:57       ` Doug Ledford
     [not found]         ` <506CB4D8.4010604-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-10-03 22:02           ` Hefty, Sean
     [not found]             ` <1828884A29C6694DAF28B7E6B8A8237346A98E8E-Q3cL8pyY+6ukrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2012-10-03 22:05               ` Doug Ledford [this message]
2012-10-04  1:47               ` Steve Wise
     [not found]                 ` <506CEAC1.9070808-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2012-10-04  5:41                   ` Or Gerlitz
     [not found]                     ` <506D2174.10601-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2012-10-04 14:27                       ` Steve Wise
     [not found]                         ` <506D9CD2.20606-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2012-10-04 15:01                           ` Hefty, Sean
     [not found]                             ` <1828884A29C6694DAF28B7E6B8A8237346A99126-Q3cL8pyY+6ukrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2012-10-04 15:08                               ` Steve Wise
2012-10-03 22:38   ` Hefty, Sean
     [not found]     ` <1828884A29C6694DAF28B7E6B8A8237346A98ECB-Q3cL8pyY+6ukrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2012-10-04 13:55       ` Marciniszyn, Mike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=506CB6BB.10102@redhat.com \
    --to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.