From: Paolo Bonzini <pbonzini@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: aliguori@us.ibm.com, akong@redhat.com,
Eduardo Habkost <ehabkost@redhat.com>,
gleb@redhat.com, jan.kiszka@siemens.com, Don@cloudswitch.com,
mtosatti@redhat.com, qemu-devel@nongnu.org,
mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com,
hpa@linux.intel.com, lersek@redhat.com, afaerber@suse.de,
stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 07/23] target-i386: convert cpuid features into properties
Date: Thu, 04 Oct 2012 09:20:54 +0200 [thread overview]
Message-ID: <506D38D6.6010906@redhat.com> (raw)
In-Reply-To: <20121004085322.599a19ab@nial.usersys.redhat.com>
Il 04/10/2012 08:53, Igor Mammedov ha scritto:
> IMHO from general POV it's not correct to set properties before object is
> completely created.
> But Anthony wants to keep qdev_prop_set_globals() qdev only thing, so could
> we move it from device_initfn() to qdev_init() or some other place then?
Yes, moving it qdev_init would work. I don't like it particularly but
hey...
Paolo
next prev parent reply other threads:[~2012-10-04 7:22 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 15:36 [Qemu-devel] [PATCH 00/23 v4] target-i386: convert CPU features into properties Igor Mammedov
2012-10-02 15:36 ` [Qemu-devel] [PATCH 01/23] target-i386: return Error from cpu_x86_find_by_name() Igor Mammedov
2012-10-10 14:05 ` Andreas Färber
2012-10-10 14:38 ` Igor Mammedov
2012-10-10 16:37 ` Luiz Capitulino
2012-10-02 15:36 ` [Qemu-devel] [PATCH 02/23] target-i386: cpu_x86_register(): report error from property setter Igor Mammedov
2012-10-10 14:07 ` Andreas Färber
2012-10-02 15:36 ` [Qemu-devel] [PATCH 03/23] target-i386: if x86_cpu_realize() failed report error and do cleanup Igor Mammedov
2012-10-10 14:09 ` Andreas Färber
2012-10-02 15:36 ` [Qemu-devel] [PATCH 04/23] target-i386: filter out not TCG features if running without kvm at realize time Igor Mammedov
2012-10-02 15:36 ` [Qemu-devel] [PATCH 05/23] target-i386: move out CPU features initialization in separate func Igor Mammedov
2012-10-02 15:36 ` [Qemu-devel] [PATCH 06/23] target-i386: xlevel should be more than 0x80000000, move fixup into setter Igor Mammedov
2012-10-02 15:36 ` [Qemu-devel] [PATCH 07/23] target-i386: convert cpuid features into properties Igor Mammedov
2012-10-02 20:38 ` Eduardo Habkost
2012-10-03 15:03 ` Eduardo Habkost
2012-10-03 15:20 ` Paolo Bonzini
2012-10-03 16:24 ` Igor Mammedov
2012-10-03 16:54 ` Eduardo Habkost
2012-10-04 6:53 ` Igor Mammedov
2012-10-04 7:20 ` Paolo Bonzini [this message]
2012-10-04 12:43 ` Eduardo Habkost
2012-10-04 12:57 ` Andreas Färber
2012-10-04 13:06 ` Eduardo Habkost
2012-10-04 13:10 ` Igor Mammedov
2012-10-04 13:19 ` Eduardo Habkost
2012-10-04 13:01 ` Igor Mammedov
2012-10-04 13:10 ` Eduardo Habkost
2012-10-04 13:25 ` Igor Mammedov
2012-10-04 13:33 ` Eduardo Habkost
2012-10-04 13:50 ` Igor Mammedov
2012-10-04 14:20 ` Eduardo Habkost
2012-10-02 15:37 ` [Qemu-devel] [PATCH 08/23] target-i386: add stubs for hyperv_(vapic_recommended|relaxed_timing_enabled|get_spinlock_retries)() Igor Mammedov
2012-10-02 15:37 ` [Qemu-devel] [PATCH 09/23] target-i386: convert 'hv_spinlocks' feature into property Igor Mammedov
2012-10-02 15:37 ` [Qemu-devel] [PATCH 10/23] target-i386: convert 'hv_relaxed' " Igor Mammedov
2012-10-02 15:37 ` [Qemu-devel] [PATCH 11/23] target-i386: convert 'hv_vapic' " Igor Mammedov
2012-10-02 15:37 ` [Qemu-devel] [PATCH 12/23] target-i386: convert 'check' and 'enforce' features into properties Igor Mammedov
2012-10-02 15:37 ` [Qemu-devel] [PATCH 13/23] add visitor for parsing hz[KMG] input string Igor Mammedov
2012-10-02 15:37 ` [Qemu-devel] [PATCH 14/23] target-i386: use visit_type_hz to parse tsc_freq property value Igor Mammedov
2012-10-02 15:37 ` [Qemu-devel] [PATCH 15/23] target-i386: introduce vendor-override property Igor Mammedov
2012-10-02 15:37 ` [Qemu-devel] [PATCH 16/23] target-i386: use define for cpuid vendor string size Igor Mammedov
2012-10-02 15:37 ` [Qemu-devel] [PATCH 17/23] target-i386: postpone cpuid_level update to realize time Igor Mammedov
2012-10-02 15:37 ` [Qemu-devel] [PATCH 18/23] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t Igor Mammedov
2012-10-02 15:37 ` [Qemu-devel] [PATCH 19/23] target-i386: parse cpu_model string into set of stringified properties Igor Mammedov
2012-10-02 15:37 ` [Qemu-devel] [PATCH 20/23] target-i386: use properties to set/unset user specified features on CPU Igor Mammedov
2012-10-02 16:01 ` Eduardo Habkost
2012-10-02 16:12 ` Igor Mammedov
2012-10-02 15:37 ` [Qemu-devel] [PATCH 21/23] target-i386: move init of "hypervisor" feature into CPU initializer from cpudef Igor Mammedov
2012-10-02 15:37 ` [Qemu-devel] [PATCH 22/23] target-i386: move default init of cpuid_kvm_features bitmap " Igor Mammedov
2012-10-02 15:37 ` [Qemu-devel] [PATCH 23/23] target-i386: cleanup cpu_x86_find_by_name(), only fill x86_def_t in it Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506D38D6.6010906@redhat.com \
--to=pbonzini@redhat.com \
--cc=Don@cloudswitch.com \
--cc=afaerber@suse.de \
--cc=akong@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=ehabkost@redhat.com \
--cc=gleb@redhat.com \
--cc=hpa@linux.intel.com \
--cc=imammedo@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=lersek@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.