From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility Date: Thu, 04 Oct 2012 12:48:59 +0200 Message-ID: <506D699B.3000609@siemens.com> References: <20120930191146.GA20012@amt.cnet> <50694EC1.8060006@siemens.com> <20121001093102.GA14797@amt.cnet> <50696E9E.7030302@siemens.com> <87zk468h3y.fsf@codemonkey.ws> <506999ED.6010409@siemens.com> <20121003095532.GO23096@redhat.com> <506C1A1D.4020209@redhat.com> <506C3B7C.408@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Lucas Meneghel Rodrigues , Gleb Natapov , kvm , Scott Moser , Marcelo Tosatti , Michael Tokarev , qemu-devel , Anthony Liguori , Cole Robinson , =?ISO-8859-1?Q?Andreas_F=E4rber?= To: Paolo Bonzini Return-path: Received: from goliath.siemens.de ([192.35.17.28]:20003 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754194Ab2JDKtT (ORCPT ); Thu, 4 Oct 2012 06:49:19 -0400 In-Reply-To: <506C3B7C.408@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 2012-10-03 15:19, Paolo Bonzini wrote: > Il 03/10/2012 12:57, Lucas Meneghel Rodrigues ha scritto: >> Yep, I did send patches with the testdev device present on qemu-kvm.git >> to qemu.git a while ago, but there were many comments on the review, I >> ended up not implementing everything that was asked and the patches were >> archived. >> >> If nobody wants to step up to port it, I'll re-read the original thread >> and will spin up new patches (and try to go through the end with it). >> Executing the KVM unittests is something that we can't afford to lose, >> so I'd say it's important on this last mile effort to get rid of qemu-kvm. > > Absolutely, IIRC the problem was that testdev did a little bit of > everything... let's see what's the functionality of testdev: > > - write (port 0xf1), can be replaced in autotest with: > -device isa-debugcon,iobase=0xf1,chardev=... > > - exit code (port 0xf4), see this series: > http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg00818.html > > - ram size (port 0xd1). If we can also patch kvm-unittests, the memory > is available in the CMOS or in fwcfg. Here is the SeaBIOS code: > > u32 rs = ((inb_cmos(0x34) << 16) | (inb_cmos(0x35) << 24)); > if (rs) > rs += 16 * 1024 * 1024; > else > rs = (((inb_cmos(0x30) << 10) | (inb_cmos(0x31) << 18)) > + 1 * 1024 * 1024); > > The rest (ports 0xe0..0xe7, 0x2000..0x2017, MMIO) can be left in testdev. IIRC, one of the biggest problem with testdev was its hack to inject interrupts. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJizN-0004q6-SI for qemu-devel@nongnu.org; Thu, 04 Oct 2012 06:49:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJizJ-00035Z-IX for qemu-devel@nongnu.org; Thu, 04 Oct 2012 06:49:09 -0400 Received: from goliath.siemens.de ([192.35.17.28]:15802) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJizJ-00035L-96 for qemu-devel@nongnu.org; Thu, 04 Oct 2012 06:49:05 -0400 Message-ID: <506D699B.3000609@siemens.com> Date: Thu, 04 Oct 2012 12:48:59 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20120930191146.GA20012@amt.cnet> <50694EC1.8060006@siemens.com> <20121001093102.GA14797@amt.cnet> <50696E9E.7030302@siemens.com> <87zk468h3y.fsf@codemonkey.ws> <506999ED.6010409@siemens.com> <20121003095532.GO23096@redhat.com> <506C1A1D.4020209@redhat.com> <506C3B7C.408@redhat.com> In-Reply-To: <506C3B7C.408@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] qemu-kvm: remove "boot=on|off" drive parameter compatibility List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Lucas Meneghel Rodrigues , Gleb Natapov , kvm , Scott Moser , Marcelo Tosatti , Michael Tokarev , qemu-devel , Anthony Liguori , Cole Robinson , =?ISO-8859-1?Q?Andreas_F=E4rber?= On 2012-10-03 15:19, Paolo Bonzini wrote: > Il 03/10/2012 12:57, Lucas Meneghel Rodrigues ha scritto: >> Yep, I did send patches with the testdev device present on qemu-kvm.git >> to qemu.git a while ago, but there were many comments on the review, I >> ended up not implementing everything that was asked and the patches were >> archived. >> >> If nobody wants to step up to port it, I'll re-read the original thread >> and will spin up new patches (and try to go through the end with it). >> Executing the KVM unittests is something that we can't afford to lose, >> so I'd say it's important on this last mile effort to get rid of qemu-kvm. > > Absolutely, IIRC the problem was that testdev did a little bit of > everything... let's see what's the functionality of testdev: > > - write (port 0xf1), can be replaced in autotest with: > -device isa-debugcon,iobase=0xf1,chardev=... > > - exit code (port 0xf4), see this series: > http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg00818.html > > - ram size (port 0xd1). If we can also patch kvm-unittests, the memory > is available in the CMOS or in fwcfg. Here is the SeaBIOS code: > > u32 rs = ((inb_cmos(0x34) << 16) | (inb_cmos(0x35) << 24)); > if (rs) > rs += 16 * 1024 * 1024; > else > rs = (((inb_cmos(0x30) << 10) | (inb_cmos(0x31) << 18)) > + 1 * 1024 * 1024); > > The rest (ports 0xe0..0xe7, 0x2000..0x2017, MMIO) can be left in testdev. IIRC, one of the biggest problem with testdev was its hack to inject interrupts. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux