From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37064) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJjx6-0005e0-Mr for qemu-devel@nongnu.org; Thu, 04 Oct 2012 07:50:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJjx4-00089X-5m for qemu-devel@nongnu.org; Thu, 04 Oct 2012 07:50:52 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:27431) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJjx3-00086R-TS for qemu-devel@nongnu.org; Thu, 04 Oct 2012 07:50:50 -0400 Received: from eusync4.samsung.com (mailout4.w1.samsung.com [210.118.77.14]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MBD00G8JA9I2020@mailout4.w1.samsung.com> for qemu-devel@nongnu.org; Thu, 04 Oct 2012 12:51:18 +0100 (BST) Received: from [106.109.8.9] by eusync4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MBD002UQA8JL370@eusync4.samsung.com> for qemu-devel@nongnu.org; Thu, 04 Oct 2012 12:50:44 +0100 (BST) Message-id: <506D7812.4030202@samsung.com> Date: Thu, 04 Oct 2012 15:50:42 +0400 From: Evgeny Voevodin MIME-version: 1.0 References: <1349149837-4821-1-git-send-email-e.voevodin@samsung.com> In-reply-to: <1349149837-4821-1-git-send-email-e.voevodin@samsung.com> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] hw/arm_gic.c: Fix improper DPRINTF output. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Evgeny Voevodin Cc: peter.maydell@linaro.org, kyungmin.park@samsung.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, e.gorelkina@samsung.com On 10/02/2012 07:50 AM, Evgeny Voevodin wrote: > s->cpu_enabled is an array, so s->cpu_enabled ? "En" : "Dis" returns > "En" always. We should use s->cpu_enabled[cpu] here. > > Signed-off-by: Evgeny Voevodin > --- > hw/arm_gic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm_gic.c b/hw/arm_gic.c > index 55871fa..4024dae 100644 > --- a/hw/arm_gic.c > +++ b/hw/arm_gic.c > @@ -566,7 +566,7 @@ static void gic_cpu_write(gic_state *s, int cpu, int offset, uint32_t value) > switch (offset) { > case 0x00: /* Control */ > s->cpu_enabled[cpu] = (value & 1); > - DPRINTF("CPU %d %sabled\n", cpu, s->cpu_enabled ? "En" : "Dis"); > + DPRINTF("CPU %d %sabled\n", cpu, s->cpu_enabled[cpu] ? "En" : "Dis"); > break; > case 0x04: /* Priority mask */ > s->priority_mask[cpu] = (value & 0xff); Did anybody pick this up? -- Kind regards, Evgeny Voevodin, Technical Leader, Mobile Group, Samsung Moscow Research Center, e-mail: e.voevodin@samsung.com