All of lore.kernel.org
 help / color / mirror / Atom feed
From: Archit Taneja <a0393947@ti.com>
To: Omar Ramirez Luna <omar.luna@linaro.org>,
	"paul@pwsan.com" <paul@pwsan.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	Rajendra Nayak <rnayak@ti.com>
Subject: Issue with _are_all_hardreset_lines_asserted()
Date: Thu, 4 Oct 2012 18:45:58 +0530	[thread overview]
Message-ID: <506D8C0E.8010600@ti.com> (raw)

Hi,

I was trying out the linux-next kernel, and I noticed that DSS 
MODULEMODE bits are never cleared.

In _omap4_disable_module(), there is a check:

	...

	if (!_are_all_hardreset_lines_asserted(oh))
		return 0;

	/* MODULEMODE bits cleared here */
	...
	...
	...

The function _are_all_hardreset_lines_asserted() returns false if 
'oh->rst_lines_cnt == 0', so we bail out from _omap4_disable_module() 
before clearing the MODULEMODE bits.

Is this correct behavior? This would prevent all hwmods who have 
rst_lines_cnt as 0 to not get their MODULEMODE bits cleared.

Thanks,
Archit

             reply	other threads:[~2012-10-04 13:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-04 13:15 Archit Taneja [this message]
2012-10-09  5:38 ` Issue with _are_all_hardreset_lines_asserted() Paul Walmsley
2012-10-09  6:43   ` Archit Taneja
2012-10-09  6:59     ` Paul Walmsley
2012-10-09  8:38       ` Hiremath, Vaibhav
2012-10-10  2:21   ` Omar Ramirez Luna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=506D8C0E.8010600@ti.com \
    --to=a0393947@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=omar.luna@linaro.org \
    --cc=paul@pwsan.com \
    --cc=rnayak@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.