Re: [Qemu-devel] [PATCH V5 06/14] hw/9pfs: Open and create files

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1391 bytes --]

On 12/14/2011 06:20 AM, M. Mohan Kumar wrote:
> From: "M. Mohan Kumar" <mohan@in.ibm.com>
> 
> Add interfaces to open and create files for proxy file system driver.
> 
> Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
> ---
>  fsdev/virtfs-proxy-helper.c |  178 ++++++++++++++++++++++++++++++++++++++++-
>  hw/9pfs/virtio-9p-proxy.c   |  187 +++++++++++++++++++++++++++++++++++++++++--
>  hw/9pfs/virtio-9p-proxy.h   |   11 +++
>  3 files changed, 367 insertions(+), 9 deletions(-)
> 

> +static int setfsugid(int uid, int gid)
> +{
> +    /*
> +     * We still need DAC_OVERRIDE because  we don't change
> +     * supplementary group ids, and hence may be subjected DAC rules
> +     */
> +    cap_value_t cap_list[] = {
> +        CAP_DAC_OVERRIDE,
> +    };
> +
> +    setfsgid(gid);
> +    setfsuid(uid);

Fedora 17 now complains about this:

  CC    fsdev/virtfs-proxy-helper.o
fsdev/virtfs-proxy-helper.c: In function ‘setfsugid’:
fsdev/virtfs-proxy-helper.c:293:13: error: ignoring return value of
‘setfsgid’, declared with attribute warn_unused_result
[-Werror=unused-result]
fsdev/virtfs-proxy-helper.c:294:13: error: ignoring return value of
‘setfsuid’, declared with attribute warn_unused_result
[-Werror=unused-result]

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 617 bytes --]