diff for duplicates of <506DD9B4.40409@wwwdotorg.org> diff --git a/a/1.txt b/N1/1.txt index c742cfc..7361e8a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -6,7 +6,7 @@ A patch description would be useful for something like this. > new file mode 100644 ... > +Usage in backend -> +======== +> +================ Everything before that point in the file looks fine to me. @@ -15,7 +15,8 @@ implementation details. Does it really belong in the DT binding documentation, rather than some Linux-specific documentation file? > +struct drm_display_mode -> +===========> + +> +======================= +> + > + +----------+---------------------------------------------+----------+-------+ > + | | | | | ↑ > + | | | | | | @@ -69,14 +70,14 @@ in order to say where those other values are referenced to. > +static int parse_property(struct device_node *np, char *name, > + struct timing_entry *result) -> + if (cells = 1) +> + if (cells == 1) > + ret = of_property_read_u32_array(np, name, &result->typ, cells); Should that branch not just set result->min/max to typ as well? Presumably it'd prevent any code that interprets struct timing_entry from having to check if those values were 0 or not? -> + else if (cells = 3) +> + else if (cells == 3) > + ret = of_property_read_u32_array(np, name, &result->min, cells); > +struct display_timings *of_get_display_timing_list(struct device_node *np) @@ -110,7 +111,7 @@ specified, although I agree that it makes sense in practice. I wonder if that shouldn't be an error? -> + if (strcmp(default_timing, entry->full_name) = 0) +> + if (strcmp(default_timing, entry->full_name) == 0) > + disp->default_timing = disp->num_timings; Hmm. Why not compare the node pointers rather than the name? Also, if diff --git a/a/content_digest b/N1/content_digest index f754d44..2b61aee 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\01349373560-11128-2-git-send-email-s.trumtrar@pengutronix.de\0" "From\0Stephen Warren <swarren@wwwdotorg.org>\0" "Subject\0Re: [PATCH 1/2 v6] of: add helper to parse display timings\0" - "Date\0Thu, 04 Oct 2012 18:47:16 +0000\0" + "Date\0Thu, 04 Oct 2012 12:47:16 -0600\0" "To\0Steffen Trumtrar <s.trumtrar@pengutronix.de>\0" "Cc\0devicetree-discuss@lists.ozlabs.org" linux-fbdev@vger.kernel.org @@ -20,7 +20,7 @@ "> new file mode 100644\n" "...\n" "> +Usage in backend\n" - "> +========\n" + "> +================\n" "\n" "Everything before that point in the file looks fine to me.\n" "\n" @@ -29,7 +29,8 @@ "documentation, rather than some Linux-specific documentation file?\n" "\n" "> +struct drm_display_mode\n" - "> +===========> +\n" + "> +=======================\n" + "> +\n" "> + +----------+---------------------------------------------+----------+-------+\n" "> + | | | | | \342\206\221\n" "> + | | | | | |\n" @@ -83,14 +84,14 @@ "> +static int parse_property(struct device_node *np, char *name,\n" "> +\t\t\t\tstruct timing_entry *result)\n" "\n" - "> +\tif (cells = 1)\n" + "> +\tif (cells == 1)\n" "> +\t\tret = of_property_read_u32_array(np, name, &result->typ, cells);\n" "\n" "Should that branch not just set result->min/max to typ as well?\n" "Presumably it'd prevent any code that interprets struct timing_entry\n" "from having to check if those values were 0 or not?\n" "\n" - "> +\telse if (cells = 3)\n" + "> +\telse if (cells == 3)\n" "> +\t\tret = of_property_read_u32_array(np, name, &result->min, cells);\n" "\n" "> +struct display_timings *of_get_display_timing_list(struct device_node *np)\n" @@ -124,7 +125,7 @@ "\n" "I wonder if that shouldn't be an error?\n" "\n" - "> +\t\tif (strcmp(default_timing, entry->full_name) = 0)\n" + "> +\t\tif (strcmp(default_timing, entry->full_name) == 0)\n" "> +\t\t\tdisp->default_timing = disp->num_timings;\n" "\n" "Hmm. Why not compare the node pointers rather than the name? Also, if\n" @@ -165,4 +166,4 @@ "If this function checks that a default-timing property exists, shouldn't\n" the function be named of_display_default_timing_exists()? -720ca4e59ce3be022801640d9a51e7be5bc386b6b85fe2bc84b3f820b3fa845b +03314568a1f3fca96c1ea91a54e0eb2a06c8d66b5d15f6fed551715598401cc9
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.