From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Sandbox: Add spi driver to sandbox
Date: Thu, 4 Oct 2012 15:23:17 -0700 [thread overview]
Message-ID: <506E0C55.9060306@ti.com> (raw)
In-Reply-To: <1349345664-30236-1-git-send-email-viktor.krivak@gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/04/12 03:14, viktor.krivak at gmail.com wrote:
> From: Viktor Krivak <viktor.krivak@gmail.com>
>
> Signed-off-by: Viktor Krivak <viktor.krivak@gmail.com>
[snip]
> +#ifndef CONFIG_SANDBOX_SPI_BUS_NUM + #define
> CONFIG_SANDBOX_SPI_BUS_NUM 1 +#endif + +#ifndef
> CONFIG_SANDBOX_SPI_CS_NUM + #define CONFIG_SANDBOX_SPI_CS_NUM 1
> +#endif + +#ifndef CONFIG_SANDBOX_SPI_BUFFER_LEN + #define
> CONFIG_SANDBOX_SPI_BUFFER_LEN 32 +#endif
Please just define these in the config file and fail to build when unset.
[snip]
> +/* + * spi_cs_is_valid() - Check if bus and cs are valid number +
> * + * @bus: Bus id + * @cs: Chip select id + * + * Compare bus and
> cs against defined constant. Return 0 if everything is ok + * and
> other value on error. + */
Almost kernel-doc style, but that needs /**, please update globally.
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
iQIcBAEBAgAGBQJQbgxVAAoJENk4IS6UOR1Wo18P/jrHcuWPckQ+gLsxbT1lZXaV
3iNeozB6rZOvrrMhbt8HKn83GclUrA8Od6NCMtW9U0DRBPn1mEJL1HlUe4TwYlPO
rtRQhvTQdaly1M9TFKCs4KKbedrJuypiQf9ToLW6qkHDC4ocDPg81Rsp2PtBdqB7
joFwd2xlpSAyaBxJpRk0+K98Qt6MxwU/C1c6pdZCgWCyaFAspg5VSEtX+Y6y3oG/
x1z9E8y/dVJqCyuMdXWch3fLsMFLFB/iFCyfgg649cNC40xuHc7rRO2rAdNDU9u7
wZ3aS/35Nm0iFL7JRL1sgcswUrPu0eqK24b+Mq+anfp+4z8vk0oh5pXYN0qi9uEW
QCB0jqNzhJQS0ZzZI6hY40DGzGXHdYHNB56BUlR/TW19QYFjeLNJAizbTFsTxC3v
u1U5u+vmZqoXo3VaX9G5WoxDpHYSLGMOon8B8aeU7BuBKLMZL+BE10Sfd2ubesto
AHG9nXPSkDfnyOmZXsG3RrdNNo0x9klGnKrUKC1tROaDKzqvcVH6M8WrHRBU7nX4
5khTph/tZZ+ZShBAMa1EGA5E9htqswDi2P6S4CUIIHD4DrAInY/S0/3Y/Z7Bv2IJ
r3okMqawaHOpwTklFHxJVFtlZIBnCHHlVD8BiUfAFR0IyOz5gMYuekPkrAJ8Mo4E
AGH8N0JH/AmaFFpxvmF4
=bGe/
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2012-10-04 22:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 10:14 [U-Boot] [PATCH] Sandbox: Add spi driver to sandbox viktor.krivak at gmail.com
2012-10-04 22:23 ` Tom Rini [this message]
2012-10-09 12:14 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506E0C55.9060306@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.