Re: [PATCH 4/4] audio: Add check for non-a2dp codec

[Chan-yeol Park <chanyeol.park@samsung.com>]

Hi All,

On 10/05/2012 05:30 AM, Marcel Holtmann wrote:
> Hi Luiz,
>
>>>>> This patch adds checks(vendor ID, vendor specific codec ID) to make sure of
>>>>> non-a2dp codec selection.
>>>>> ---
>>>>>   audio/a2dp-codecs.h |    6 +++++
>>>>>   audio/a2dp.c        |   68 ++++++++++++++++++++++++++++++++++++++++++++++++++-
>>>>>   2 files changed, 73 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/audio/a2dp-codecs.h b/audio/a2dp-codecs.h
>>>>> index 51c796a..e3d2cba 100644
>>>>> --- a/audio/a2dp-codecs.h
>>>>> +++ b/audio/a2dp-codecs.h
>>>>> @@ -26,6 +26,7 @@
>>>>>   #define A2DP_CODEC_MPEG12              0x01
>>>>>   #define A2DP_CODEC_MPEG24              0x02
>>>>>   #define A2DP_CODEC_ATRAC               0x03
>>>>> +#define A2DP_CODEC_NON_A2DP            0xFF
>>>> I prefer A2DP_CODEC_VENDOR
>>> what is the specification calling these? And yes, I would prefer VENDOR
>>> as well.
>> Apparently it comes from the assigned numbers
>> http://www.bluetooth.org/Technical/AssignedNumbers/audio-video.htm:
>>
>> 1	1	1	1	1	1	1	1	non-A2DP	n/a	A2DP
>>
>> But the spec refer to it as 4.7 Vendor Specific A2DP Codec, IMO the
>> term non-A2DP can be confused with not defined in A2DP spec when in
>> fact it is defined:
>>
>> "4.2.3 Vendor Specific A2DP Codecs
>> The device may support other codecs as Vendor Specific A2DP codecs. A
>> user of a Vendor Specific A2DP codec (hereafter the Vendor) will need
>> to define parameters and other information necessary for use of the
>> codec in A2DP."
>>
>> There is no such a thing as non-A2DP in the spec, so again to avoid
>> confusion I would stick to the terminology vendor or vendor specific.
> lets use "vendor" for these. Otherwise the function and variable naming
> gets too complicated.
As you guided I prefer "vendor" codec rather than "non-a2dp" codec. I 
just follow the word in the spec 1.2 because current bluez A2DP version 
is 1.2.  Actually A2DP spec changes the name of 0xff codec from 1.2 to 
1.3 like the below.

1.4 Bluetooth A2DP Profile Change History
1.4.1 Changes from 1.2 to 1.3
1.4.1.1 General Changes
· Non-A2DP codecs from A2DP 1.2 are now referred to as Vendor-Specific 
A2DP codecs

Anyway I think "vendor" is more suitable than "non-a2dp".
I will raise a second patch.

Regards
Chanyeol