From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TK0dZ-0001za-7u for qemu-devel@nongnu.org; Fri, 05 Oct 2012 01:39:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TK0dY-0002ll-8T for qemu-devel@nongnu.org; Fri, 05 Oct 2012 01:39:49 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:47779) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TK0dY-0002lh-25 for qemu-devel@nongnu.org; Fri, 05 Oct 2012 01:39:48 -0400 Message-ID: <506E72A0.8010300@weilnetz.de> Date: Fri, 05 Oct 2012 07:39:44 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1349346964-4151-1-git-send-email-avi@redhat.com> <87626phdn0.fsf@codemonkey.ws> In-Reply-To: <87626phdn0.fsf@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Jia Liu , qemu-devel@nongnu.org, Blue Swirl , Max Filippov , Michael Walle , Avi Kivity , "Edgar E. Iglesias" , Aurelien Jarno , Paul Brook Am 05.10.2012 04:10, schrieb Anthony Liguori: > Avi Kivity writes: > >> The hassle and compile time overhead of maintaining both 32-bit and 64-bit >> capable source isn't worth the tiny performance advantage which is seen on >> a minority of configurations. Switch to compiling libhw only once, with >> target_phys_addr_t unconditionally typedefed to uint64_t. >> >> Signed-off-by: Avi Kivity > Applied. Thanks. > > Regards, > > Anthony Liguori > In a next step, we can remove libhw completely: All files from libhw/hw/*.o could as well be generated in hw/*.o, and hw-obj should become common-obj. Or is there still a reason why libhw is needed? Regards Stefan W.