From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37502)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TK2EE-0000V7-L2
	for qemu-devel@nongnu.org; Fri, 05 Oct 2012 03:21:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TK2E9-0004FU-06
	for qemu-devel@nongnu.org; Fri, 05 Oct 2012 03:21:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:25655)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TK2E8-0004FO-OD
	for qemu-devel@nongnu.org; Fri, 05 Oct 2012 03:21:40 -0400
Message-ID: <506E8A7B.6040900@redhat.com>
Date: Fri, 05 Oct 2012 09:21:31 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1349287077-10062-1-git-send-email-sandmann@cs.au.dk>
	<506D5A74.5040904@redhat.com> <ye8391ucfex.fsf@llama05.cs.au.dk>
In-Reply-To: <ye8391ucfex.fsf@llama05.cs.au.dk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] qxl: Default to PCI revision 4 when
 spice-server is new enough
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?U8O4cmVuIFNhbmRtYW5u?= <sandmann@cs.au.dk>
Cc: =?UTF-8?B?U8O4cmVuIFNhbmRtYQ==?= =?UTF-8?B?bm4gUGVkZXJzZW4=?= <ssp@redhat.com>, qemu-devel@nongnu.org, kraxel@redhat.com

Il 04/10/2012 19:31, S=C3=B8ren Sandmann ha scritto:
>> >
>> > No, that's not possible.  The revision must be the same for all mach=
ines
>> > started with the same "-M" argument.  So your only choice is to make
>> > 0.12 a requirement for QEMU 1.3.  Then you can use compatibility
>> > properties (see the long list of strings in hw/pc_piix.c) to ensure =
that
>> > pc-1.2 and earlier machines use the previous revision.
> Spice server 0.12 is already, so I'll send a patch to require that
> unconditionally. I'm assuming that later strings override earlier ones
> so that the revision=3D3 I added won't take effect for previous machine=
s.

There is a PC_COMPAT_1_2 macro, just add the

        {\
            .driver   =3D "qxl-vga",\
            .property =3D "revision",\
            .value    =3D "3",\
        },{\
        {\
            .driver   =3D "qxl",\
            .property =3D "revision",\
            .value    =3D "3",\
        },{\

there.

Paolo