From: Mark Tinguely <tinguely@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] xfs: introduce XFS_BMAPI_STACK_SWITCH
Date: Fri, 05 Oct 2012 08:27:43 -0500 [thread overview]
Message-ID: <506EE04F.9010508@sgi.com> (raw)
In-Reply-To: <1349399219-13024-2-git-send-email-david@fromorbit.com>
On 10/04/12 20:06, Dave Chinner wrote:
> From: Dave Chinner<dchinner@redhat.com>
>
> Certain allocation paths through xfs_bmapi_write() are in situations
> where we have limited stack available. These are almost always in
> the buffered IO writeback path when convertion delayed allocation
> extents to real extents.
>
> The current stack switch occurs for userdata allocations, which
> means we also do stack switches for preallocation, direct IO and
> unwritten extent conversion, even those these call chains have never
> been implicated in a stack overrun.
>
> Hence, let's target just the single stack overun offended for stack
> switches. To do that, introduce a XFS_BMAPI_STACK_SWITCH flag that
> the caller can pass xfs_bmapi_write() to indicate it should switch
> stacks if it needs to do allocation.
>
> Signed-off-by: Dave Chinner<dchinner@redhat.com>
> ---
Looks good.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-10-05 13:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 1:06 [PATCH 0/2] xfs: fix AGF/alloc workqueue deadlock Dave Chinner
2012-10-05 1:06 ` [PATCH 1/2] xfs: introduce XFS_BMAPI_STACK_SWITCH Dave Chinner
2012-10-05 13:27 ` Mark Tinguely [this message]
2012-10-05 1:06 ` [PATCH 2/2] xfs: move allocation stack switch up to xfs_bmapi_allocate Dave Chinner
2012-10-05 13:28 ` Mark Tinguely
2012-10-18 22:51 ` [PATCH 0/2] xfs: fix AGF/alloc workqueue deadlock Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506EE04F.9010508@sgi.com \
--to=tinguely@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.