From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60665)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TK9I6-0005Ni-7V
	for qemu-devel@nongnu.org; Fri, 05 Oct 2012 10:54:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TK9I0-0002Uk-D1
	for qemu-devel@nongnu.org; Fri, 05 Oct 2012 10:54:14 -0400
Received: from cantor2.suse.de ([195.135.220.15]:60947 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TK9I0-0002UY-6S
	for qemu-devel@nongnu.org; Fri, 05 Oct 2012 10:54:08 -0400
Message-ID: <506EF48B.5070002@suse.de>
Date: Fri, 05 Oct 2012 16:54:03 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <cover.1345730024.git.agarcia@igalia.com>
	<20120831141231.GA18777@igalia.com> <5040E1A7.4010401@suse.de>
	<20121005132036.GA29555@igalia.com>
In-Reply-To: <20121005132036.GA29555@igalia.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232
 IndustryPack emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alberto Garcia <agarcia@igalia.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, Paul Brook <paul@codesourcery.com>, Paolo Bonzini <pbonzini@redhat.com>

Am 05.10.2012 15:20, schrieb Alberto Garcia:
> On Fri, Aug 31, 2012 at 06:09:11PM +0200, Andreas F=E4rber wrote:
>=20
>>> Ping
>>
>> We are currently in Hard Freeze, new devices will not get accepted
>> before the release, and our review may focus on bug fixes.
>>
>> http://wiki.qemu.org/Planning/1.2
>>
>> I remember having had a brief look through your patches and
>> they looked pretty good modeling- and style-wise for an initial
>> submission. Don't know the hardware though and haven't tested the
>> patches so far.
>=20
> I wrote a small blog post about the work, including a bit more
> information on how to test it:
>=20
> http://blogs.igalia.com/berto/2012/10/03/industrypack-qemu-and-linuxcon=
/

Thanks for the illustrative blog post.

One thing caught my eye: Wouldn't it make more sense to call the device
"ipoctal232"? Octal doesn't indicate of what there are eight. ;)

> Is there anything else I should do in order to have this reviewed, or
> should I contact someone else?

Paul and Peter are the ones with experience reviewing UARTs, I think.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg