From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52346)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1TKBdN-0002sh-3r
	for qemu-devel@nongnu.org; Fri, 05 Oct 2012 13:24:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1TKBdM-0003sC-3j
	for qemu-devel@nongnu.org; Fri, 05 Oct 2012 13:24:21 -0400
Received: from goliath.siemens.de ([192.35.17.28]:15689)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1TKBdL-0003rs-Qe
	for qemu-devel@nongnu.org; Fri, 05 Oct 2012 13:24:20 -0400
Message-ID: <506F17C1.6090704@siemens.com>
Date: Fri, 05 Oct 2012 19:24:17 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <20121005171338.092840368@amt.cnet>
	<20121005171442.485802711@amt.cnet>
In-Reply-To: <20121005171442.485802711@amt.cnet>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [patch 5/7] Emulate qemu-kvms drive parameter
	boot=on|off
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

On 2012-10-05 19:13, Marcelo Tosatti wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Releases of qemu-kvm will be interrupted at qemu 1.3.0.
> Users should switch to plain qemu releases.
> To avoid breaking scenarios which are setup with command line
> options specific to qemu-kvm, port these switches from qemu-kvm
> to qemu.git.
> 
> Port drive boot option. From the qemu-kvm original commit message:
> 
> We do not want to maintain this option forever. It will be removed after
> a grace period of a few releases. So warn the user that this option has
> no effect and will become invalid soon.
> 
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> 
> Index: qemu-compat-kvm/blockdev.c
> ===================================================================
> --- qemu-compat-kvm.orig/blockdev.c
> +++ qemu-compat-kvm/blockdev.c
> @@ -432,6 +432,12 @@ DriveInfo *drive_init(QemuOpts *opts, in
>          return NULL;
>      }
>  
> +    if (qemu_opt_get(opts, "boot") != NULL) {
> +        fprintf(stderr, "qemu-kvm: boot=on|off is deprecated and will be "
> +                "ignored. Future versions will reject this parameter. Please "
> +                "update your scripts.\n");
> +    }
> +
>      on_write_error = BLOCK_ERR_STOP_ENOSPC;
>      if ((buf = qemu_opt_get(opts, "werror")) != NULL) {
>          if (type != IF_IDE && type != IF_SCSI && type != IF_VIRTIO && type != IF_NONE) {
> Index: qemu-compat-kvm/qemu-config.c
> ===================================================================
> --- qemu-compat-kvm.orig/qemu-config.c
> +++ qemu-compat-kvm/qemu-config.c
> @@ -114,6 +114,10 @@ static QemuOptsList qemu_drive_opts = {
>              .name = "copy-on-read",
>              .type = QEMU_OPT_BOOL,
>              .help = "copy read data from backing file into image file",
> +        },{
> +            .name = "boot",
> +            .type = QEMU_OPT_BOOL,
> +            .help = "(deprecated, ignored)",
>          },
>          { /* end of list */ }
>      },
> 
> 

Same as with patch 3: nothing is emulated, only a warning issued.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux