From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKCzu-0001Yx-Eo for qemu-devel@nongnu.org; Fri, 05 Oct 2012 14:51:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TKCzt-0004es-6J for qemu-devel@nongnu.org; Fri, 05 Oct 2012 14:51:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22075) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKCzs-0004em-Sn for qemu-devel@nongnu.org; Fri, 05 Oct 2012 14:51:41 -0400 Message-ID: <506F2C32.4010909@redhat.com> Date: Fri, 05 Oct 2012 12:51:30 -0600 From: Eric Blake MIME-Version: 1.0 References: <1349460425-30601-1-git-send-email-coreyb@linux.vnet.ibm.com> <1349460425-30601-4-git-send-email-coreyb@linux.vnet.ibm.com> <506F2730.6090106@redhat.com> <506F2A9D.6050605@linux.vnet.ibm.com> In-Reply-To: <506F2A9D.6050605@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigB61C283301B737E7A761501B" Subject: Re: [Qemu-devel] [PATCH 3/4] qemu-config: Add -drive fd and opaque options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corey Bryant Cc: Blue Swirl , libvir-list@redhat.com, qemu-devel@nongnu.org, kwolf@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigB61C283301B737E7A761501B Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/05/2012 12:44 PM, Corey Bryant wrote: > Yes, this makes more sense. I'd like to mirror the add-fd QMP command > as much as possible: >=20 > { 'command': 'add-fd', 'data': {'*fdset-id': 'int', '*opaque': 'str'}, > 'returns': 'AddfdInfo' } >=20 > So maybe we can make it: >=20 > -add-fd fd=3D24,fdset-id=3D1,opaque=3D"rdonly" -add-fd > fd=3D25,fdset-id=3D1,opaque=3D"rdwr" Sounds better. Note that while fdset-id is optional in QMP, I think it needs to be mandatory on the CLI (you're telling qemu to use an inherited fd, but unless you know what set that fd belongs to, you can't then refer to that fd elsewhere on the command line, and unlike the QMP command, there is no venue for QMP to tell you what set was autocreated).= Bike-shedding: I think the command line can be slightly shorter with: -add-fd fd=3D24,set=3D1,opaque=3D... with no real loss in information (that is, s/fdset-id/set/), since our command lines are already quite long. But going longhand to match QMP doesn't hurt my feelings (libvirt will be automating this all anyway, so I won't really be typing it by hand). --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigB61C283301B737E7A761501B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQbywzAAoJEKeha0olJ0NqPDQH/0fXNY11eiNpI46/SkkogL8f TnTqGxueDFX3/x6/Gyv6RCw1AlxIQUfpTPyr4xCi1jUHTQf1jkFx3bmKS+/iV8lZ bxHr61DL+94TQnvp1yKYXX2WjDUl0VDknMhovSuBg7XG3ky8VS5BMsVKXrYar+/H hc3hlWSMIor++ePlx3pC8g7iqt2l2DpgUFbTqAGy93HQ1zQFCfZA+E2yF00qZ69n XA+0N310Q1Sw+0kpD/wn6y1YL2fLIw06YZCgMxUr7PvKgP+7Qjq+EXXbnpdYNJqF QswKEwWvg00tUdx9SgE0wim0qRsxk6O2gPDZKVl0y+O3HNXVv9XC8omewbS5pJk= =SSCr -----END PGP SIGNATURE----- --------------enigB61C283301B737E7A761501B--