From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
rdunlap@xenotime.net, arve@android.com, kernel-team@android.com,
john.stultz@linaro.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ
Date: Fri, 05 Oct 2012 13:48:23 -0600 [thread overview]
Message-ID: <506F3987.9020902@linaro.org> (raw)
In-Reply-To: <20121005181608.GA24356@core.coreip.homeip.net>
On 12-10-05 12:16 PM, Dmitry Torokhov wrote:
> On Fri, Oct 05, 2012 at 11:59:29AM -0600, mathieu.poirier@linaro.org wrote:
>> From: "Mathieu J. Poirier" <mathieu.poirier@linaro.org>
>>
>> Andrew,
>>
>> After requesting a number of changes that, to my understanding
>> have been implemented, I have not been able to get the attention
>> of the subsystem maintainer on this patch.
>>
>> If there are still issues, I'm open to making changes but I want
>> to make sure it doesn't get forgotten. If there no objections,
>> would you consider queuint it ?
>
> Mathieu,
>
> I have the same objection as before: using platform device solely for
> the purpose of passing some data from board code to the driver. Surely
> there are other ways of passing this bit of data... What about, for
> example, making it an empty weak symbol so that board code could
> override it with strong one?
Thanks for the comments - I will implement a weak function in the
keyreset driver.
Mathieu.
>
> Thanks.
>
next prev parent reply other threads:[~2012-10-05 19:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 17:59 [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ mathieu.poirier
2012-10-05 18:16 ` Dmitry Torokhov
2012-10-05 18:53 ` Alan Cox
2012-10-05 19:08 ` Dmitry Torokhov
2012-10-05 19:48 ` Mathieu Poirier [this message]
2012-10-17 3:35 ` Arve Hjønnevåg
2012-10-20 16:38 ` Mathieu Poirier
2012-10-21 6:19 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2012-08-27 21:43 mathieu.poirier
2012-08-27 23:34 ` Randy Dunlap
2012-08-28 10:55 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506F3987.9020902@linaro.org \
--to=mathieu.poirier@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arve@android.com \
--cc=dmitry.torokhov@gmail.com \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.