From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] FAT: check for partition 0 not 1 for whole-disk fs
Date: Fri, 05 Oct 2012 17:36:08 -0600 [thread overview]
Message-ID: <506F6EE8.7060308@wwwdotorg.org> (raw)
In-Reply-To: <506F6CE4.8080802@ti.com>
On 10/05/2012 05:27 PM, Tom Rini wrote:
> On 10/05/12 16:17, Stephen Warren wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>
>> The recent switch to use get_device_and_partition() from
>> do_fat_ls() broke the ability to access a FAT filesystem
>> directly on a whole device; FAT only works within a partition on
>> a device.
>
>> This change makes e.g. "fatls mmc 0:0" work; explicitly
>> requesting partition ID 0 is something that
>> get_device_and_partition() fully supports. However,
>> fat_register_device() expects partition ID 1 to be used in the
>> full-disk case; partition ID 1 was previously implicitly
>> specified when the user didn't actually specify a partition ID.
>> Update fat_register_device() to expect the correct ID.
>
>> This change does imply that if a user explicitly executes "fatls
>> mmc 0:1" then this will fail, and may be a change in behaviour.
>
> So wait, you can't list device 0, bus 1 after this patch?
That's partition 1 not bus 1.
In the context of having a raw FAT filesystem on a device with no
partition table, the partition specification "0:1" doesn't work before
or after this patch; I believe (if it worked at all ever before) it
was broken by the previous get_device_and_partition() rework.
If you do have a partition table, then "0:1" works just fine
with/without this patch.
>> Note that this still prevents "fatls mmc 0:auto" from working.
>> The next patch will fix that.
>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com> --- Tom, this
>> series is really a bug-fix and should go in before the 9-long
>> series I posted earlier today. I'll need to rebase that other
>> series on top of this and repost, once any comments are
>> addressed.
>
> Should this also go in the release?
I imagine so; that's why I rebased it below the previous series I sent
which I assume isn't going into this release.
next prev parent reply other threads:[~2012-10-05 23:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 23:17 [U-Boot] [PATCH 1/2] FAT: check for partition 0 not 1 for whole-disk fs Stephen Warren
2012-10-05 23:17 ` [U-Boot] [PATCH 2/2] disk: part_dos: don't claim whole-disk FAT filesystems Stephen Warren
2012-10-08 18:47 ` [U-Boot] [U-Boot, " Tom Rini
2012-10-05 23:27 ` [U-Boot] [PATCH 1/2] FAT: check for partition 0 not 1 for whole-disk fs Tom Rini
2012-10-05 23:36 ` Stephen Warren [this message]
2012-10-05 23:39 ` Tom Rini
2012-10-05 23:46 ` Stephen Warren
2012-10-08 18:47 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506F6EE8.7060308@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.