From: Avi Kivity <avi@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Jia Liu <proljc@gmail.com>,
qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Michael Walle <michael@walle.cc>,
Paul Brook <paul@codesourcery.com>,
Anthony Liguori <anthony@codemonkey.ws>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally
Date: Sun, 07 Oct 2012 15:16:33 +0200 [thread overview]
Message-ID: <507180B1.5060302@redhat.com> (raw)
In-Reply-To: <CAFEAcA--j+Od8-4+SeoVUZsENn41o2eRe9KYYGveSzNtZTpuew@mail.gmail.com>
On 10/05/2012 06:45 PM, Peter Maydell wrote:
> On 4 October 2012 11:36, Avi Kivity <avi@redhat.com> wrote:
>> diff --git a/targphys.h b/targphys.h
>> index bd4938f..08cade9 100644
>> --- a/targphys.h
>> +++ b/targphys.h
>> @@ -3,25 +3,10 @@
>> #ifndef TARGPHYS_H
>> #define TARGPHYS_H
>>
>> -#ifdef TARGET_PHYS_ADDR_BITS
>> +#define TARGET_PHYS_ADDR_BITS 64
>> /* target_phys_addr_t is the type of a physical address (its size can
>> be different from 'target_ulong'). */
>
> I've just noticed that this change means that linux-user binaries
> now get a definition of target_phys_addr_t (where previously they
> did not get that type at all). Was this intentional,
No.
> and does it make sense?
Not much. Not very harmful either. If you want it removed, I can post
a patch.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2012-10-07 13:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 10:36 [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally Avi Kivity
2012-10-04 10:42 ` Edgar E. Iglesias
2012-10-04 11:42 ` Max Filippov
2012-10-04 13:56 ` Anthony Liguori
2012-10-04 16:54 ` Blue Swirl
2012-10-04 17:08 ` Michael Walle
2012-10-04 18:15 ` Stefan Weil
2012-10-07 10:25 ` Avi Kivity
2012-10-05 2:10 ` Anthony Liguori
2012-10-05 5:39 ` Stefan Weil
2012-10-05 15:46 ` Blue Swirl
2012-10-05 16:07 ` Anthony Liguori
2012-10-05 16:45 ` Peter Maydell
2012-10-07 13:16 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507180B1.5060302@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=jcmvbkbc@gmail.com \
--cc=michael@walle.cc \
--cc=paul@codesourcery.com \
--cc=peter.maydell@linaro.org \
--cc=proljc@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.