From: Haicheng Li <haicheng.li@linux.intel.com>
To: David Miller <davem@davemloft.net>
Cc: fengguang.wu@intel.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] Fix PTP dependencies: explicitly select all the possible dependencies.
Date: Sun, 07 Oct 2012 22:14:29 +0800 [thread overview]
Message-ID: <50718E45.1070706@linux.intel.com> (raw)
In-Reply-To: <20121006.171748.734171045678392820.davem@davemloft.net>
Fengguang reported a kernel build failure as following:
drivers/built-in.o: In function `pch_gbe_ioctl':
pch_gbe_main.c:(.text+0x510370): undefined reference to `pch_ch_control_write'
pch_gbe_main.c:(.text+0x510393): undefined reference to `pch_ch_control_write'
pch_gbe_main.c:(.text+0x5103b3): undefined reference to `pch_ch_control_write'
...
It's a regression by commit da1586461. The root cause is that
the CONFIG_PPS is not set there, consequently CONFIG_PTP_1588_CLOCK
can not be set anyway, which finally causes ptp_pch and pch_gbe_main
build failures.
As David prefers to use *select* to fix such module co-dependency issues,
this patch explicitly selects all the possible dependencies of PCH_PTP.
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Reviewed-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Haicheng Li <haicheng.lee@gmail.com>
---
drivers/net/ethernet/oki-semi/pch_gbe/Kconfig | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
index 9730241..5296cc8 100644
--- a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
@@ -26,6 +26,9 @@ if PCH_GBE
config PCH_PTP
bool "PCH PTP clock support"
default n
+ depends on EXPERIMENTAL
+ select PPS
+ select PTP_1588_CLOCK
select PTP_1588_CLOCK_PCH
---help---
Say Y here if you want to use Precision Time Protocol (PTP) in the
--
1.7.1
next prev parent reply other threads:[~2012-10-07 14:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-06 7:59 [net:master 1/9] pch_gbe_main.c:(.text+0x510370): undefined reference to `pch_ch_control_write' Fengguang Wu
2012-10-06 11:31 ` Francois Romieu
2012-10-06 13:22 ` David Miller
2012-10-06 12:07 ` Haicheng Li
2012-10-06 13:22 ` David Miller
2012-10-06 14:07 ` Haicheng Li
2012-10-06 14:21 ` David Miller
2012-10-06 17:21 ` Haicheng Li
2012-10-06 21:17 ` David Miller
2012-10-07 14:14 ` Haicheng Li [this message]
2012-10-07 18:54 ` [PATCH] Fix PTP dependencies: explicitly select all the possible dependencies David Miller
2012-10-06 14:56 ` [net:master 1/9] pch_gbe_main.c:(.text+0x510370): undefined reference to `pch_ch_control_write' Richard Cochran
[not found] ` <1349670580-11158-1-git-send-email-haicheng.lee@gmail.com>
2012-10-08 11:15 ` [PATCH] pch_pge: Fix build error by selecting all the possible dependencies Haicheng Li
[not found] ` <1349695107-19524-1-git-send-email-haicheng.lee@gmail.com>
2012-10-08 18:48 ` [PATCH] pch_gbe: " David Miller
2012-10-09 9:43 ` Haicheng Li
2012-10-09 17:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50718E45.1070706@linux.intel.com \
--to=haicheng.li@linux.intel.com \
--cc=davem@davemloft.net \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.