All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gregor Jasny <gjasny@googlemail.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>,
	Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: ir-keytable: Bug in gen_keytables.pl script
Date: Sun, 07 Oct 2012 19:24:26 +0200	[thread overview]
Message-ID: <5071BACA.1080702@googlemail.com> (raw)

Hello,

I recently received this launchpad bug:
https://bugs.launchpad.net/ubuntu/+source/v4l-utils/+bug/1054122
It seems that the mentioned key mappings are missing.

If you check the generated mapping file

http://git.linuxtv.org/v4l-utils.git/blob/HEAD:/utils/keytable/rc_keymaps/imon_pad

and compare it to the driver file

http://git.linuxtv.org/media_tree.git/blob/refs/heads/staging/for_v3.7:/drivers/media/rc/keymaps/rc-imon-pad.c#l111

you'll notice that the parsing stopped at the BTN_xyz table entries:

>         { 0x299115b7, KEY_KEYBOARD },
>         { 0x299135b7, KEY_KEYBOARD },

processing stopped here

>         { 0x01010000, BTN_LEFT },
>         { 0x01020000, BTN_RIGHT },
>         { 0x01010080, BTN_LEFT },
>         { 0x01020080, BTN_RIGHT },
>         { 0x688301b7, BTN_LEFT },
>         { 0x688481b7, BTN_RIGHT },
> 
>         { 0x2a9395b7, KEY_CYCLEWINDOWS }, /* TaskSwitcher */
>         { 0x2b8395b7, KEY_TIME }, /* Timer */

Mauro, could you please take a look? I guess the BTN_xyz entries should
be also added to the keytable files. Unfortunately my Perl skills are
horrible.

Thanks,
Gregor

             reply	other threads:[~2012-10-07 17:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-07 17:24 Gregor Jasny [this message]
2012-10-08  1:24 ` ir-keytable: Bug in gen_keytables.pl script Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5071BACA.1080702@googlemail.com \
    --to=gjasny@googlemail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.