All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jean-Noël AVILA" <jn.avila@free.fr>
To: "Jean-Noël Avila via GitGitGadget" <gitgitgadget@gmail.com>,
	"Junio C Hamano" <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/5] doc: convert git-bisect to synopsis style
Date: Tue, 19 May 2026 22:57:29 +0200	[thread overview]
Message-ID: <5072065.GXAFRqVoOG@piment-oiseau> (raw)
In-Reply-To: <xmqq4ik5d0le.fsf@gitster.g>

On Monday, 18 May 2026 02:26:37 CEST Junio C Hamano wrote:
> "Jean-Noël Avila via GitGitGadget" <gitgitgadget@gmail.com> writes:
> > From: =?UTF-8?q?Jean-No=C3=ABl=20Avila?= <jn.avila@free.fr>
> > 
> > Convert Documentation/git-bisect.adoc to the modern synopsis style.
> > 
> > - Replace [verse] with [synopsis] in the SYNOPSIS block
> 
> This was expected.
> 
> > - Remove single quotes around command names in the synopsis
> > - Use backticks for inline commands, options, refs, and special values
> > - Apply [synopsis] attribute to in-body command-form code blocks
> 
> This is very much unexpected.  I think everybody thought [synopsis]
> was invented to be used for the SYNOPSIS section at the beginning of
> each manual page, and ...

In fact, the synopsis style was already applied before outside the SYNOPSIS 
sections in diff-generate-patch.adoc when describing the output of the -p 
option.


This formatting reaches beyond the synopsis, but the rationale is simple. Each 
time a listing contains some <placeholder>, what is actually described is a 
model, not an actual output. The <placeholder> needs a special formatting to 
convey its special meaning.

That may mean that the naming of "synopsis style" may not be adequate.

> 
> >  SYNOPSIS
> >  --------
> > 
> > -[verse]
> > -'git bisect' start [--term-(bad|new)=<term-new> --term-(good|old)=<term-
old>]
> > -		   [--no-checkout] [--first-parent] [<bad> [<good>...]] 
[--] [<pathspec>...]
> > ...
> > -'git bisect' help
> > +[synopsis]
> > +git bisect start [--term-(bad|new)=<term-new> --term-(good|old)=<term-
old>]
> > +		 [--no-checkout] [--first-parent] [<bad> [<good>...]] [--] 
[<pathspec>...]
> > ...
> > +git bisect help
> 
> ... a change like this is very much expected and understandable, but
> 
> new appearances of [synonsis] in places like:
> > +[synopsis]
> > 
> >  ------------------------------------------------
> >  $ git bisect reset <commit>
> >  ------------------------------------------------
> 
> and
> 
> > +[synopsis]
> > 
> >  ------------------------------------------------
> >  git bisect old [<rev>]
> >  ------------------------------------------------
> 
> were a bit surprising and confusing.  They are not exactly command
> syntax definitions (which is the SYNOPSIS section is about), but
> examples of usage. 

Are they? the "[<rev>]" block is typical of synopsis syntax, not something you 
would actually type in.

> The one with '$' command line prompt feels
> particularly confusing, as the prompt is not something that the
> end-user gives, unlike what we write in the synopsis section.
> 

The '$' is an error to me. Will fix.

> Other than that, this is quite exciting.





  parent reply	other threads:[~2026-05-19 20:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-17 20:26 [PATCH 0/5] doc: convert another batch of files to synopsis style Jean-Noël Avila via GitGitGadget
2026-05-17 20:26 ` [PATCH 1/5] doc: convert git-bisect " Jean-Noël Avila via GitGitGadget
2026-05-18  0:26   ` Junio C Hamano
2026-05-18  2:10     ` Junio C Hamano
2026-05-19 21:03       ` Jean-Noël AVILA
2026-05-19 20:57     ` Jean-Noël AVILA [this message]
2026-05-17 20:26 ` [PATCH 2/5] doc: convert git-grep synopsis and options to new style Jean-Noël Avila via GitGitGadget
2026-05-17 20:26 ` [PATCH 3/5] doc: convert git-am " Jean-Noël Avila via GitGitGadget
2026-05-17 20:26 ` [PATCH 4/5] doc: convert git-apply " Jean-Noël Avila via GitGitGadget
2026-05-17 20:26 ` [PATCH 5/5] doc: convert git-imap-send " Jean-Noël Avila via GitGitGadget
2026-05-25 10:28 ` [PATCH v2 0/6] doc: convert another batch of files to synopsis style Jean-Noël Avila via GitGitGadget
2026-05-25 10:28   ` [PATCH v2 1/6] doc: convert git-bisect " Jean-Noël Avila via GitGitGadget
2026-05-25 10:28   ` [PATCH v2 2/6] doc: git bisect: clarify the usage of the synopsis vs actual command Jean-Noël Avila via GitGitGadget
2026-05-25 10:28   ` [PATCH v2 3/6] doc: convert git-grep synopsis and options to new style Jean-Noël Avila via GitGitGadget
2026-05-25 10:28   ` [PATCH v2 4/6] doc: convert git-am " Jean-Noël Avila via GitGitGadget
2026-05-25 10:28   ` [PATCH v2 5/6] doc: convert git-apply " Jean-Noël Avila via GitGitGadget
2026-05-25 10:28   ` [PATCH v2 6/6] doc: convert git-imap-send " Jean-Noël Avila via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5072065.GXAFRqVoOG@piment-oiseau \
    --to=jn.avila@free.fr \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.