Re: [meta-oe][PATCH v3] iw: add iw 3.6 recipe

[jhuang0 <jackie.huang@windriver.com>]

On 10/5/2012 6:20 PM, Andrei Gherzan wrote:
> Hello,
>
> On Fri, Oct 5, 2012 at 4:39 AM, <jackie.huang@windriver.com> wrote:
>
>> iw: add iw 3.6 recipe
>>
>
> Don't copy the subject here.
>
>
>>
>> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
>> ---
>>   meta-oe/recipes-connectivity/iw/iw_3.6.bb |   23 +++++++++++++++++++++++
>>   1 files changed, 23 insertions(+), 0 deletions(-)
>>   create mode 100644 meta-oe/recipes-connectivity/iw/iw_3.6.bb
>>
>> diff --git a/meta-oe/recipes-connectivity/iw/iw_3.6.bbb/meta-oe/recipes-connectivity/iw/
>> iw_3.6.bb
>> new file mode 100644
>> index 0000000..42a43c3
>> --- /dev/null
>> +++ b/meta-oe/recipes-connectivity/iw/iw_3.6.bb
>> @@ -0,0 +1,23 @@
>> +SUMMARY = "nl80211 based CLI configuration utility for wireless devices"
>> +DESCRIPTION = "iw is a new nl80211 based CLI configuration utility for \
>> +wireless devices. It supports almost all new drivers that have been added
>> \
>> +to the kernel recently. "
>> +HOMEPAGE = "http://linuxwireless.org/en/users/Documentation/iw"
>> +SECTION = "base"
>> +LICENSE = "BSD"
>> +LIC_FILES_CHKSUM = "file://COPYING;md5=878618a5c4af25e9b93ef0be1a93f774"
>> +
>> +DEPENDS = "libnl pkgconfig"
>> +
>> +SRC_URI = "http://wireless.kernel.org/download/iw/${P}.tar.bz2 \
>> +
>> file://0001-iw-version.sh-don-t-use-git-describe-for-versioning.patch \
>> +          "
>> +
>> +SRC_URI[md5sum] = "1c18bfbbc8773629e5e8ac733a39540c"
>> +SRC_URI[sha256sum] =
>> "df11036ac11df31f44083da962a6e9c74bdea7c01c596c4b5840f948cdb6c857"
>> +
>> +EXTRA_OEMAKE = ""
>> +
>>
>
> Do you really need this?

Yes, in the Makefile, pkg-config commands is used to get libraries info 
and then modify CFLAGS and LIBS accordingly, but they will be overrode 
with the -e option in typical EXTRA_OEMAKE, so I need this to drop the 
-e option.

>
> +do_install() {
>> +       oe_runmake DESTDIR=${D} install
>>
>
> Why don't you add DESTDIR=${D} to EXTRA_OEMAKE and drop the install rule?

It will do nothing with the default intall rule, I just kept the same 
way used in the 3.2 recipe.

Thanks,
Jackie

>
> ag
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

-- 
Jackie Huang
WIND RIVER | China Development Center
MSN:jackielily@hotmail.com
Tel: +86 8477 8594
Mobile: +86 138 1027 4745