From: David Henningsson <david.henningsson@canonical.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, 1060729@bugs.launchpad.net
Subject: Re: [PATCH] ALSA: hda - avoid unneccesary indices on "Headphone Jack" controls
Date: Mon, 08 Oct 2012 11:02:37 +0200 [thread overview]
Message-ID: <507296AD.8090405@canonical.com> (raw)
In-Reply-To: <s5h391pl6lr.wl%tiwai@suse.de>
On 10/08/2012 10:18 AM, Takashi Iwai wrote:
> At Wed, 3 Oct 2012 11:12:53 +0200,
> David Henningsson wrote:
>>
>> In case there is one "Headphone Jack" and one "Dock Headphone Jack",
>> one of them will get an index, even though that is not needed.
>> This patch fixes that issue.
>>
>> BugLink: https://bugs.launchpad.net/bugs/1060729
>> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
>
> Applied. This one doesn't need to go to stable, right?
Good question. I guess it depends on how we look upon kcontrol indices
in general.
PulseAudio never picks anything up if it has an index, therefore it
becomes a real problem/bug for users. (Not sure if one could argue that
this is a problem in PulseAudio rather than the kernel. Haven't thought
that through.)
OTOH, if the reasoning is that you would break custom made scripts that
depend on this index, i e it becomes a change of behaviour.
To be pragmatic about it, the chances that people are depending on this
index being non-zero are probably very low, so I don't mind sending this
one to stable.
--
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
prev parent reply other threads:[~2012-10-08 9:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 9:12 [PATCH] ALSA: hda - avoid unneccesary indices on "Headphone Jack" controls David Henningsson
2012-10-08 8:18 ` Takashi Iwai
2012-10-08 9:02 ` David Henningsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507296AD.8090405@canonical.com \
--to=david.henningsson@canonical.com \
--cc=1060729@bugs.launchpad.net \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.