From: "Péter Ujfalusi" <peter.ujfalusi@ti.com>
To: Liam Girdwood <lrg@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH] ASoC: dmaengine: Correct Makefile when sound is built as module
Date: Mon, 08 Oct 2012 14:50:56 +0300 [thread overview]
Message-ID: <5072BE20.9040400@ti.com> (raw)
In-Reply-To: <1349083766-17076-1-git-send-email-peter.ujfalusi@ti.com>
Hi Mark,
On 10/01/2012 12:29 PM, Peter Ujfalusi wrote:
> soc-dmaengine-pcm library need to be part of the snd-soc-core in order to
> be able to compile ASoC as modules when dmaengine is enabled on the platform.
Would it be possible to schedule this patch for 3.7? I'm sure if you build any
platform which uses dmaegine for audio and compile the audio as module you
will also have errors about missing symbols.
Thank you,
Péter
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> sound/soc/Makefile | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/Makefile b/sound/soc/Makefile
> index bcbf1d0..99f32f7 100644
> --- a/sound/soc/Makefile
> +++ b/sound/soc/Makefile
> @@ -1,8 +1,9 @@
> snd-soc-core-objs := soc-core.o soc-dapm.o soc-jack.o soc-cache.o soc-utils.o
> snd-soc-core-objs += soc-pcm.o soc-compress.o soc-io.o
>
> -snd-soc-dmaengine-pcm-objs := soc-dmaengine-pcm.o
> -obj-$(CONFIG_SND_SOC_DMAENGINE_PCM) += snd-soc-dmaengine-pcm.o
> +ifneq ($(CONFIG_SND_SOC_DMAENGINE_PCM),)
> +snd-soc-core-objs += soc-dmaengine-pcm.o
> +endif
>
> obj-$(CONFIG_SND_SOC) += snd-soc-core.o
> obj-$(CONFIG_SND_SOC) += codecs/
>
next prev parent reply other threads:[~2012-10-08 11:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-01 9:29 [PATCH] ASoC: dmaengine: Correct Makefile when sound is built as module Peter Ujfalusi
2012-10-08 11:50 ` Péter Ujfalusi [this message]
2012-10-09 4:15 ` Mark Brown
2012-10-09 6:57 ` Mark Brown
2012-10-09 6:58 ` Mark Brown
2012-10-09 9:07 ` Péter Ujfalusi
2012-10-09 9:08 ` Mark Brown
2012-10-09 13:16 ` Péter Ujfalusi
2012-10-10 1:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5072BE20.9040400@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.