From: "Tapani Pälli" <tapani.palli@intel.com>
To: Oliver McFadden <oliver.mcfadden@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] Android.mk: use LOCAL_COPY_HEADERS to export headers. v2
Date: Mon, 08 Oct 2012 15:45:00 +0300 [thread overview]
Message-ID: <5072CACC.4040605@intel.com> (raw)
In-Reply-To: <20121008114300.GF13854@omcfadde-MOBL1.fi.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 1916 bytes --]
On 10/08/2012 02:43 PM, Oliver McFadden wrote:
> On Mon, Oct 08, 2012 at 12:23:56PM +0300, Tapani Pälli wrote:
>> From: Haitao Huang <haitao.huang@intel.com>
>>
>> Export necessary header files used by other components for Android,
>> such as libva intel-driver, gralloc, hwcomposer, etc.
>>
>> Signed-off-by: Haitao Huang <haitao.huang@intel.com>
>> [chad: Fixed inconsistent indentation.]
>> Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
>> ---
>
> Normal syntax is "Subject: [PATCH v2 N/M] ..." You should add a comment
> here describing the v1..v2 diff.
ok, I took away the gerrit 'change-id' row, I'll send v3 with your
suggested changes.
>> Android.mk | 12 +++++++++++-
>> 1 file changed, 11 insertions(+), 1 deletion(-)
>>
>> diff --git a/Android.mk b/Android.mk
>> index 1029dc6..68db5df 100644
>> --- a/Android.mk
>> +++ b/Android.mk
>> @@ -1,5 +1,5 @@
>> #
>> -# Copyright © 2011 Intel Corporation
>> +# Copyright © 2011-2012 Intel Corporation
>> #
>> # Permission is hereby granted, free of charge, to any person obtaining a
>> # copy of this software and associated documentation files (the "Software"),
>> @@ -45,6 +45,16 @@ LOCAL_C_INCLUDES := \
>> LOCAL_CFLAGS := \
>> -DHAVE_LIBDRM_ATOMIC_PRIMITIVES=1
>>
>> +LOCAL_COPY_HEADERS := \
>> + xf86drm.h \
>> + include/drm/drm_fourcc.h \
>> + include/drm/drm.h \
>> + include/drm/drm_mode.h \
>> + include/drm/drm_sarea.h \
>> + include/drm/i915_drm.h \
>> + intel/intel_bufmgr.h \
>> +
>> +LOCAL_COPY_HEADERS_TO := libdrm
>> include $(BUILD_SHARED_LIBRARY)
>>
>> include $(LOCAL_PATH)/intel/Android.mk
>> --
>> 1.7.11.7
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
// Tapani
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 551 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2012-10-08 12:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 9:23 [PATCH] Android.mk: use LOCAL_COPY_HEADERS to export headers. v2 Tapani Pälli
2012-10-08 11:43 ` Oliver McFadden
2012-10-08 12:45 ` Tapani Pälli [this message]
2012-10-10 17:01 ` Chad Versace
2012-10-11 8:55 ` Tapani Pälli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5072CACC.4040605@intel.com \
--to=tapani.palli@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=oliver.mcfadden@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.