From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] of: add stub of_get_child_by_name for non-OF builds
Date: Mon, 08 Oct 2012 08:47:45 -0500 [thread overview]
Message-ID: <5072D981.7090801@gmail.com> (raw)
In-Reply-To: <1349631654-20931-1-git-send-email-olof@lixom.net>
On 10/07/2012 12:40 PM, Olof Johansson wrote:
> Fixes build error on s3c6400_defconfig, introduced by commit
> 06455bbcab76e5f5225de5f38ab948d37a1c3587, "dt/s3c64xx/spi: Use
> of_get_child_by_name to get a named child".
>
> drivers/spi/spi-s3c64xx.c: In function 's3c64xx_get_slave_ctrldata':
> drivers/spi/spi-s3c64xx.c:838:2: error: implicit declaration of function
> 'of_get_child_by_name' [-Werror=implicit-function-declaration]
>
> Signed-off-by: Olof Johansson <olof@lixom.net>
> ---
Applied, thanks.
Rob
> include/linux/of.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/include/linux/of.h b/include/linux/of.h
> index 72843b7..b4e50d5 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -331,6 +331,13 @@ static inline bool of_have_populated_dt(void)
> #define for_each_child_of_node(parent, child) \
> while (0)
>
> +static inline struct device_node *of_get_child_by_name(
> + const struct device_node *node,
> + const char *name)
> +{
> + return NULL;
> +}
> +
> static inline int of_get_child_count(const struct device_node *np)
> {
> return 0;
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] of: add stub of_get_child_by_name for non-OF builds
Date: Mon, 08 Oct 2012 08:47:45 -0500 [thread overview]
Message-ID: <5072D981.7090801@gmail.com> (raw)
In-Reply-To: <1349631654-20931-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
On 10/07/2012 12:40 PM, Olof Johansson wrote:
> Fixes build error on s3c6400_defconfig, introduced by commit
> 06455bbcab76e5f5225de5f38ab948d37a1c3587, "dt/s3c64xx/spi: Use
> of_get_child_by_name to get a named child".
>
> drivers/spi/spi-s3c64xx.c: In function 's3c64xx_get_slave_ctrldata':
> drivers/spi/spi-s3c64xx.c:838:2: error: implicit declaration of function
> 'of_get_child_by_name' [-Werror=implicit-function-declaration]
>
> Signed-off-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
> ---
Applied, thanks.
Rob
> include/linux/of.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/include/linux/of.h b/include/linux/of.h
> index 72843b7..b4e50d5 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -331,6 +331,13 @@ static inline bool of_have_populated_dt(void)
> #define for_each_child_of_node(parent, child) \
> while (0)
>
> +static inline struct device_node *of_get_child_by_name(
> + const struct device_node *node,
> + const char *name)
> +{
> + return NULL;
> +}
> +
> static inline int of_get_child_count(const struct device_node *np)
> {
> return 0;
>
next prev parent reply other threads:[~2012-10-08 13:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 17:40 [PATCH] of: add stub of_get_child_by_name for non-OF builds Olof Johansson
2012-10-07 17:40 ` Olof Johansson
2012-10-08 13:47 ` Rob Herring [this message]
2012-10-08 13:47 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5072D981.7090801@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.