Re: [linux-platform-drivers-x86:review-hans 37/38] drivers/platform/x86/firmware_attributes_class.c:16:5: warning: no previous prototype for function 'fw_attributes_class_get'

[Hans de Goede <hdegoede@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2867 bytes --]

Hi Mark,

On 5/27/21 5:44 PM, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git review-hans
> head:   9972d91cd41540a1890435034b62653c98da4261
> commit: 8535b9dea34f00781758999285cea8ab82bb0a2f [37/38] platform/x86: dell-wmi-sysman: Use firmware_attributes_class helper
> config: x86_64-randconfig-r032-20210527 (attached as .config)
> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 6505c630407c5feec818f0bb1c284f9eeebf2071)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install x86_64 cross compiling tool for clang build
>         # apt-get install binutils-x86-64-linux-gnu
>         # https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?id=8535b9dea34f00781758999285cea8ab82bb0a2f
>         git remote add linux-platform-drivers-x86 https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git
>         git fetch --no-tags linux-platform-drivers-x86 review-hans
>         git checkout 8535b9dea34f00781758999285cea8ab82bb0a2f
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
>>> drivers/platform/x86/firmware_attributes_class.c:16:5: warning: no previous prototype for function 'fw_attributes_class_get' [-Wmissing-prototypes]
>    int fw_attributes_class_get(struct class **fw_attr_class)
>        ^
>    drivers/platform/x86/firmware_attributes_class.c:16:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>    int fw_attributes_class_get(struct class **fw_attr_class)
>    ^
>    static 
>>> drivers/platform/x86/firmware_attributes_class.c:35:5: warning: no previous prototype for function 'fw_attributes_class_put' [-Wmissing-prototypes]
>    int fw_attributes_class_put(void)
>        ^
>    drivers/platform/x86/firmware_attributes_class.c:35:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>    int fw_attributes_class_put(void)
>    ^
>    static 
>    2 warnings generated.


Let me decode these arcane warnings for you :)

These warnings are being issues because there is no previous prototype declaration for these functions; and this is caused by drivers/platform/x86/firmware_attributes_class.c missing an:

#include "firmware_attributes_class.h"

If you add that to the discussed v5 of this series then these warning should go away.

Regards,

Hans