From: Troy Kisky <troy.kisky@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] Add nitrogen6x board
Date: Mon, 08 Oct 2012 14:24:27 -0700 [thread overview]
Message-ID: <5073448B.1080705@boundarydevices.com> (raw)
In-Reply-To: <50733F89.8080000@denx.de>
On 10/8/2012 2:03 PM, Stefano Babic wrote:
> On 08/10/2012 22:30, Troy Kisky wrote:
>> On 10/8/2012 9:05 AM, Eric Nelson wrote:
>>> Hi Stefano,
>>>
>>> On 10/08/2012 05:28 AM, Stefano Babic wrote: +
>>>>> +/* Command definition */
>>>>> +#include<config_cmd_default.h>
>>>> Move CONFIG_CMD_BMODE and CONFIG_CMD_SETEXPR here.
>>>>
>>> That makes perfect sense.
>>>
>> Moving CONFIG_CMD_BMODE may break MX51 boards.
>> Only mx6 and mx53 define boot_mode_apply function in soc.c
>>
> ???
>
> My proposal is to move the two defines after including cmd_default.h,
> but still in nitrogen6x.h. It is not possible to break mx51 boards.
>
> Regards,
> Stefano
>
Ah. That makes more sense. I thought you were suggesting moving them inside
config_cmd_default.h
next prev parent reply other threads:[~2012-10-08 21:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 19:49 [U-Boot] [PATCH 0/3] Add support for the Boundary Devices Nitrogen6x board Eric Nelson
2012-10-04 19:49 ` [U-Boot] [PATCH 1/3] Add nitrogen6x board Eric Nelson
2012-10-04 21:42 ` Sinan Akman
2012-10-04 21:51 ` Sinan Akman
2012-10-04 21:56 ` Fabio Estevam
2012-10-05 17:24 ` Albert ARIBAUD
2012-10-05 18:42 ` Eric Nelson
2012-10-05 19:00 ` Tom Rini
2012-10-05 20:03 ` Eric Nelson
2012-10-05 22:46 ` Tom Rini
2012-10-08 12:54 ` Stefano Babic
2012-10-08 17:24 ` Eric Nelson
2012-10-05 19:29 ` Albert ARIBAUD
2012-10-06 0:23 ` Eric Nelson
2012-10-08 12:28 ` Stefano Babic
2012-10-08 16:05 ` Eric Nelson
2012-10-08 20:30 ` Troy Kisky
2012-10-08 21:03 ` Stefano Babic
2012-10-08 21:24 ` Troy Kisky [this message]
2012-10-04 19:49 ` [U-Boot] [PATCH 2/3] nitrogen6x: configure and toggle PHY reset for Nitrogen6x Eric Nelson
2012-10-04 19:49 ` [U-Boot] [PATCH 3/3] nitrogen6x: initialize WL12XX pads, use to determine board type Eric Nelson
2012-10-08 12:32 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5073448B.1080705@boundarydevices.com \
--to=troy.kisky@boundarydevices.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.