All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boaz Harrosh <bharrosh@panasas.com>
To: Marco Stornelli <marco.stornelli@gmail.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
	Benny Halevy <bhalevy@tonian.com>, <osd-dev@open-osd.org>,
	<linux-kernel@vger.kernel.org>,
	Linux FS Devel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 1/8] exofs: drop lock/unlock super
Date: Mon, 8 Oct 2012 14:58:05 -0700	[thread overview]
Message-ID: <50734C6D.2000400@panasas.com> (raw)
In-Reply-To: <50700A1A.7@gmail.com>

On 10/06/2012 03:38 AM, Marco Stornelli wrote:
> Removed lock/unlock super.
> 

Hi Marco

I was sure you guys where pushing this patch through some
vfs tree. (Hence my Acked-by below). I have just sent Linus
a pull request for the 3.7 Kernel. I could perhaps append this
one and resend.

I do want this patch, and it is completely independent and can
go through my tree. Please tell me what do you want to do with
this patch, should I push it? Or are you pushing it through Al

Thanks
Boaz 

> Acked-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> Acked-by: Boaz Harrosh <bharrosh@panasas.com>
> Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
> ---
>  fs/exofs/super.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/exofs/super.c b/fs/exofs/super.c
> index 59e3bbf..5e59280 100644
> --- a/fs/exofs/super.c
> +++ b/fs/exofs/super.c
> @@ -389,8 +389,6 @@ static int exofs_sync_fs(struct super_block *sb, int wait)
>  	if (unlikely(ret))
>  		goto out;
>  
> -	lock_super(sb);
> -
>  	ios->length = offsetof(struct exofs_fscb, s_dev_table_oid);
>  	memset(fscb, 0, ios->length);
>  	fscb->s_nextid = cpu_to_le64(sbi->s_nextid);
> @@ -406,8 +404,6 @@ static int exofs_sync_fs(struct super_block *sb, int wait)
>  	if (unlikely(ret))
>  		EXOFS_ERR("%s: ore_write failed.\n", __func__);
>  
> -
> -	unlock_super(sb);
>  out:
>  	EXOFS_DBGMSG("s_nextid=0x%llx ret=%d\n", _LLU(sbi->s_nextid), ret);
>  	ore_put_io_state(ios);
> 

  reply	other threads:[~2012-10-08 21:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-06 10:38 [PATCH 1/8] exofs: drop lock/unlock super Marco Stornelli
2012-10-08 21:58 ` Boaz Harrosh [this message]
2012-10-08 23:24   ` Al Viro
2012-10-09 15:55     ` Marco Stornelli
2012-10-09 16:40       ` Al Viro
2012-10-09 17:44         ` Theodore Ts'o
2012-10-10  8:04         ` Marco Stornelli
  -- strict thread matches above, loose matches on Subject: below --
2012-08-30 14:56 Marco Stornelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50734C6D.2000400@panasas.com \
    --to=bharrosh@panasas.com \
    --cc=bhalevy@tonian.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marco.stornelli@gmail.com \
    --cc=osd-dev@open-osd.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.