From: Richard Henderson <rth@twiddle.net>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] tci: fix build breakage for target-sparc
Date: Mon, 08 Oct 2012 15:19:48 -0700 [thread overview]
Message-ID: <50735184.10803@twiddle.net> (raw)
In-Reply-To: <1349729149-6481-1-git-send-email-mdroth@linux.vnet.ibm.com>
On 10/08/2012 01:45 PM, Michael Roth wrote:
> /* Alpha and SH4 user mode emulations and Softmmu call GETPC().
> For all others, GETPC remains undefined (which makes TCI a little faster. */
> -# if defined(CONFIG_SOFTMMU) || defined(TARGET_ALPHA) || defined(TARGET_SH4)
> +# if defined(CONFIG_SOFTMMU) || defined(TARGET_ALPHA) || defined(TARGET_SH4) \
> + || defined(TARGET_SPARC)
> extern uintptr_t tci_tb_ptr;
> # define GETPC() tci_tb_ptr
Why is this conditional? All targets probably ought to be using it
when raising runtime exceptions -- particularly fp exceptions.
r~
next prev parent reply other threads:[~2012-10-08 22:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 20:45 [Qemu-devel] [PATCH] tci: fix build breakage for target-sparc Michael Roth
2012-10-08 21:03 ` [Qemu-trivial] " Stefan Weil
2012-10-08 21:03 ` Stefan Weil
2012-10-08 22:19 ` Richard Henderson [this message]
2012-10-09 5:22 ` Stefan Weil
2012-10-19 19:32 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50735184.10803@twiddle.net \
--to=rth@twiddle.net \
--cc=blauwirbel@gmail.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.