From: Huang Shijie <b32955@freescale.com>
To: Vikram Narayanan <vikram186@gmail.com>
Cc: linux-mtd@lists.infradead.org, dedekind1@gmail.com
Subject: Re: [PATCH] imx/gpmi: Make debug prints more clear
Date: Tue, 9 Oct 2012 09:43:33 +0800 [thread overview]
Message-ID: <50738145.4020102@freescale.com> (raw)
In-Reply-To: <5073061A.5040405@gmail.com>
于 2012年10月09日 00:58, Vikram Narayanan 写道:
> Hello Huang,
>
> Can you please give an ACK for this?
>
> Thanks,
> Vikram
>
> On 9/23/2012 3:18 PM, Vikram Narayanan wrote:
>> Make the error messages more debugging friendly
>>
>> Signed-off-by: Vikram Narayanan<vikram186@gmail.com>
>> Cc: Huang Shijie<b32955@freescale.com>
>> ---
>> drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 14 ++++++++------
>> 1 files changed, 8 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
>> b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
>> index 5999b15..24fbfb8 100644
>> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
>> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
>> @@ -222,7 +222,7 @@ void prepare_data_dma(struct gpmi_nand_data
>> *this, enum dma_data_direction dr)
>>
>> ret = dma_map_sg(this->dev, sgl, 1, dr);
>> if (ret == 0)
>> - pr_err("map failed.\n");
>> + pr_err("DMA mapping failed.\n");
>>
>> this->direct_dma_map_ok = false;
>> }
>> @@ -456,7 +456,7 @@ static int __devinit acquire_dma_channels(struct
>> gpmi_nand_data *this)
>>
>> dma_chan = dma_request_channel(mask, gpmi_dma_filter, this);
>> if (!dma_chan) {
>> - pr_err("dma_request_channel failed.\n");
>> + pr_err("Failed to request DMA channel.\n");
>> goto acquire_err;
>> }
>>
>> @@ -630,7 +630,8 @@ static int read_page_prepare(struct
>> gpmi_nand_data *this,
>> length, DMA_FROM_DEVICE);
>> if (dma_mapping_error(dev, dest_phys)) {
>> if (alt_size< length) {
>> - pr_err("Alternate buffer is too small\n");
>> + pr_err("%s, Alternate buffer is too small\n",
>> + __func__);
>> return -ENOMEM;
>> }
>> goto map_failed;
>> @@ -680,7 +681,8 @@ static int send_page_prepare(struct
>> gpmi_nand_data *this,
>> DMA_TO_DEVICE);
>> if (dma_mapping_error(dev, source_phys)) {
>> if (alt_size< length) {
>> - pr_err("Alternate buffer is too small\n");
>> + pr_err("%s, Alternate buffer is too small\n",
>> + __func__);
>> return -ENOMEM;
>> }
>> goto map_failed;
>> @@ -768,7 +770,7 @@ static int gpmi_alloc_dma_buffer(struct
>> gpmi_nand_data *this)
>>
>> error_alloc:
>> gpmi_free_dma_buffer(this);
>> - pr_err("allocate DMA buffer ret!!\n");
>> + pr_err("Error allocating DMA buffers!\n");
>> return -ENOMEM;
>> }
>>
>> @@ -1479,7 +1481,7 @@ static int gpmi_set_geometry(struct
>> gpmi_nand_data *this)
>> /* Set up the NFC geometry which is used by BCH. */
>> ret = bch_set_geometry(this);
>> if (ret) {
>> - pr_err("set geometry ret : %d\n", ret);
>> + pr_err("Error setting BCH geometry : %d\n", ret);
>> return ret;
>> }
>>
>
>
thanks.
Acked-by: Huang Shijie <b32955@freescale.com>
next prev parent reply other threads:[~2012-10-09 1:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-23 9:48 [PATCH] imx/gpmi: Make debug prints more clear Vikram Narayanan
2012-10-08 16:58 ` Vikram Narayanan
2012-10-09 1:43 ` Huang Shijie [this message]
2012-10-10 12:48 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50738145.4020102@freescale.com \
--to=b32955@freescale.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=vikram186@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.