From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga02-in.huawei.com ([119.145.14.65]:42021 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751612Ab2JIDKR (ORCPT ); Mon, 8 Oct 2012 23:10:17 -0400 Message-ID: <5073954A.6090507@huawei.com> Date: Tue, 9 Oct 2012 11:08:58 +0800 From: Jiang Liu MIME-Version: 1.0 To: Yijing Wang CC: Bjorn Helgaas , Hanjun Guo , , Yinghai Lu Subject: Re: [PATCH 0/7] disable bridge ari forwarding after connected ari device hot removed References: <1349751804-7476-1-git-send-email-wangyijing@huawei.com> In-Reply-To: <1349751804-7476-1-git-send-email-wangyijing@huawei.com> Content-Type: text/plain; charset="ISO-8859-1" Sender: linux-pci-owner@vger.kernel.org List-ID: Seems no need to change cpci/cpqphp/ibmphp/sgi/shpcihp, they all deal with PCI devices, so only need to change acpiphp and pciehp. On 2012-10-9 11:03, Yijing Wang wrote: > pci_enable_ari will be called if an ARI pci device found, then set its bridge ARI Forwarding Enable > bit in Device Control 2 Register. But the bridge ARI Forwarding Enable bit will never be cleared > when an ARI device hot removed. > > my steps: > 1. Hot add an ARI pci device; > 2. Hot remove the ARI pci device; > 3. Hot add an non ARI pci device; > > In this case, after setp 3, we could only find fun 0 of non ARI pci device because of its bridge ARI Forwarding Enable > bit set. > > As PCIe Spec 2.0(6.13/441) recommends: > "Following a hot-plug event below a Downstream Port, it is strongly recommended that software > Clear the ARI Forwarding Enable bit in the Downstream Port until software determines that a > newly added component is in fact an ARI Device" > > This series of patches fix this problem. > > Yijing Wang (7): > PCI: rework pci_enable_ari for support disable ari forwarding > PCI, acpiphp: disable ARI forwarding for acpiphp > PCI, pciehp: disable ARI forwarding for pciehp > PCI, cpqphp: disable ARI forwarding for cpqphp > PCI, shpchp: disable ARI forwarding for shpchp > PCI, sgi: disable ARI forwarding for sgiphp > PCI, ibmphp: disable ARI forwarding for ibmphp > > drivers/pci/hotplug/acpiphp_glue.c | 1 + > drivers/pci/hotplug/cpci_hotplug_pci.c | 1 + > drivers/pci/hotplug/cpqphp_pci.c | 1 + > drivers/pci/hotplug/ibmphp_core.c | 1 + > drivers/pci/hotplug/pciehp_pci.c | 1 + > drivers/pci/hotplug/sgi_hotplug.c | 1 + > drivers/pci/hotplug/shpchp_pci.c | 1 + > drivers/pci/pci.c | 16 +++++++++++----- > drivers/pci/pci.h | 2 +- > drivers/pci/probe.c | 2 +- > 10 files changed, 20 insertions(+), 7 deletions(-) > > > > . >