From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52450)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TLSH7-0000Aj-1u
	for qemu-devel@nongnu.org; Tue, 09 Oct 2012 01:22:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TLSH6-0004n7-5b
	for qemu-devel@nongnu.org; Tue, 09 Oct 2012 01:22:36 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:51351)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TLSH5-0004n2-VX
	for qemu-devel@nongnu.org; Tue, 09 Oct 2012 01:22:36 -0400
Message-ID: <5073B499.7010905@weilnetz.de>
Date: Tue, 09 Oct 2012 07:22:33 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1349729149-6481-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<50735184.10803@twiddle.net>
In-Reply-To: <50735184.10803@twiddle.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] tci: fix build breakage for target-sparc
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: blauwirbel@gmail.com, Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org

Am 09.10.2012 00:19, schrieb Richard Henderson:
> On 10/08/2012 01:45 PM, Michael Roth wrote:
>>   /* Alpha and SH4 user mode emulations and Softmmu call GETPC().
>>      For all others, GETPC remains undefined (which makes TCI a little faster. */
>> -# if defined(CONFIG_SOFTMMU) || defined(TARGET_ALPHA) || defined(TARGET_SH4)
>> +# if defined(CONFIG_SOFTMMU) || defined(TARGET_ALPHA) || defined(TARGET_SH4) \
>> +     || defined(TARGET_SPARC)
>>   extern uintptr_t tci_tb_ptr;
>>   #  define GETPC() tci_tb_ptr
> Why is this conditional?  All targets probably ought to be using it
> when raising runtime exceptions -- particularly fp exceptions.
>
>
> r~
>

See the comment: "which makes TCI a little faster".

When GETPC is undefined, tci.c saves an assignment
to a global variable per interpreted TCG code
which is a significant reduction.

Maybe there are better solutions, of course.

Regards
Stefan