From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753563Ab2JIGWV (ORCPT ); Tue, 9 Oct 2012 02:22:21 -0400 Received: from hqemgate03.nvidia.com ([216.228.121.140]:18863 "EHLO hqemgate03.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752701Ab2JIGWT (ORCPT ); Tue, 9 Oct 2012 02:22:19 -0400 X-PGP-Universal: processed; by hqnvupgp06.nvidia.com on Mon, 08 Oct 2012 23:22:17 -0700 Message-ID: <5073BAA8.4060404@nvidia.com> Date: Tue, 9 Oct 2012 11:18:24 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7 MIME-Version: 1.0 To: Mark Brown CC: "sameo@linux.intel.com" , "grant.likely@secretlab.ca" , "linus.walleij@linaro.org" , Stephen Warren , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/3] mfd: Convert tps6586x to irq_domain References: <1349712805-10014-1-git-send-email-ldewangan@nvidia.com> <1349712805-10014-2-git-send-email-ldewangan@nvidia.com> <20121009060641.GE8237@opensource.wolfsonmicro.com> In-Reply-To: <20121009060641.GE8237@opensource.wolfsonmicro.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 09 October 2012 11:36 AM, Mark Brown wrote: > On Mon, Oct 08, 2012 at 09:43:23PM +0530, Laxman Dewangan wrote: >> Allocate the irq base if it base is not porvided i.e. >> in case of device tree invocation of this driver. >> Convert the tps6586x driver to irq domain, using a >> legacy IRQ mapping if an irq_base is specified in >> platform data or dynamically allocated and otherwise >> using a linear mapping. > Reviewed-by: Mark Brown > > but can you convert to regmap_irq? Yes, the motivation was this when I started this cleanups but found that there is 4 interrupt status and 5 interrupt mask register. Probably we need to pass the number of interrupt status and interrupt mask register to expand the regmap-irq framework to handle this case also. If it is fine then I can work towards that.