All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "sameo@linux.intel.com" <sameo@linux.intel.com>,
	"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
	"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	Stephen Warren <swarren@nvidia.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] mfd: Convert tps6586x to irq_domain
Date: Tue, 9 Oct 2012 11:34:47 +0530	[thread overview]
Message-ID: <5073BE7F.5060107@nvidia.com> (raw)
In-Reply-To: <20121009062355.GJ8237@opensource.wolfsonmicro.com>

On Tuesday 09 October 2012 11:53 AM, Mark Brown wrote:
> On Tue, Oct 09, 2012 at 11:18:24AM +0530, Laxman Dewangan wrote:
>> On Tuesday 09 October 2012 11:36 AM, Mark Brown wrote:
>>> but can you convert to regmap_irq?
>> Yes, the motivation was this when I started this cleanups but found
>> that there is 4 interrupt status and 5 interrupt mask register.
>> Probably we need to pass the number of interrupt status and
>> interrupt mask register to expand the regmap-irq framework to handle
>> this case also. If it is fine then I can work towards that.
> Can you explain in more detail - I guess there's a different mapping of
> the bits into the registers for mask and status (in which case the
> generic code just won't work anyway).
The bit definitions are also different in status and mask register and 
yes, this will be again problem as we do in isr thread
  data->status_buf[i] &= ~data->mask_buf[i];

So given the constraint, generic will not work here.


  reply	other threads:[~2012-10-09  6:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-08 16:13 [PATCH 0/3] mfd: tps6586x: Convert to irq domain Laxman Dewangan
2012-10-08 16:13 ` [PATCH 1/3] mfd: Convert tps6586x to irq_domain Laxman Dewangan
2012-10-09  6:06   ` Mark Brown
2012-10-09  5:48     ` Laxman Dewangan
2012-10-09  6:23       ` Mark Brown
2012-10-09  6:04         ` Laxman Dewangan [this message]
2012-10-09  6:40           ` Mark Brown
2012-10-30 10:46             ` Laxman Dewangan
2012-10-30 10:48             ` Laxman Dewangan
2012-10-08 16:13 ` [PATCH 2/3] mfd: tps6586x: add irq io-resource for rtc sub driver Laxman Dewangan
2012-10-09  6:07   ` Mark Brown
2012-10-08 16:13 ` [PATCH 3/3] mfd: tps6586x: implement gpio_to_irq Laxman Dewangan
2012-10-09  6:07   ` Mark Brown
2012-10-10  7:49   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5073BE7F.5060107@nvidia.com \
    --to=ldewangan@nvidia.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=swarren@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.