From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51610) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLUN8-0002mf-L0 for qemu-devel@nongnu.org; Tue, 09 Oct 2012 03:37:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLUN1-0007hZ-V0 for qemu-devel@nongnu.org; Tue, 09 Oct 2012 03:36:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41903) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLUN1-0007hQ-Kv for qemu-devel@nongnu.org; Tue, 09 Oct 2012 03:36:51 -0400 Message-ID: <5073D408.20909@redhat.com> Date: Tue, 09 Oct 2012 09:36:40 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <267c819bbf776d4938d67545c9bdef6b4f03bcb0.1349749915.git.jbaron@redhat.com> In-Reply-To: <267c819bbf776d4938d67545c9bdef6b4f03bcb0.1349749915.git.jbaron@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 03/21] pci: pci capability must be in PCI space List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Baron Cc: aliguori@us.ibm.com, juzhang@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, qemu-devel@nongnu.org, agraf@suse.de, blauwirbel@gmail.com, yamahata@valinux.co.jp, alex.williamson@redhat.com, kevin@koconnor.net, avi@redhat.com, mkletzan@redhat.com, lcapitulino@redhat.com, afaerber@suse.de, armbru@redhat.com, kraxel@redhat.com Il 09/10/2012 05:30, Jason Baron ha scritto: > From: Isaku Yamahata > > pci capability must be in PCI space. > It can't lay in PCIe extended config space. > > Signed-off-by: Isaku Yamahata > Signed-off-by: Jason Baron > --- > hw/pci.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/hw/pci.c b/hw/pci.c > index f855cf3..85ebef6 100644 > --- a/hw/pci.c > +++ b/hw/pci.c > @@ -1626,12 +1626,11 @@ PCIDevice *pci_create_simple(PCIBus *bus, int devfn, const char *name) > return pci_create_simple_multifunction(bus, devfn, false, name); > } > > -static int pci_find_space(PCIDevice *pdev, uint8_t size) > +static uint8_t pci_find_space(PCIDevice *pdev, uint8_t size) > { > - int config_size = pci_config_size(pdev); > int offset = PCI_CONFIG_HEADER_SIZE; > int i; > - for (i = PCI_CONFIG_HEADER_SIZE; i < config_size; ++i) > + for (i = PCI_CONFIG_HEADER_SIZE; i < PCI_CONFIG_SPACE_SIZE; ++i) > if (pdev->used[i]) > offset = i + 1; > else if (i - offset + 1 == size) > Reviewed-by: Paolo Bonzini