From: Laxman Dewangan <ldewangan@nvidia.com>
To: Venu Byravarasu <vbyravarasu@nvidia.com>
Cc: "broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>, "lrg@ti.com" <lrg@ti.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 4/4] regulator: tps65090: add external control support for DCDC
Date: Tue, 9 Oct 2012 15:32:35 +0530 [thread overview]
Message-ID: <5073F63B.9020606@nvidia.com> (raw)
In-Reply-To: <D958900912E20642BCBC71664EFECE3E6DDF8AF6F1@BGMAIL02.nvidia.com>
On Tuesday 09 October 2012 04:03 PM, Venu Byravarasu wrote:
>> +static struct regulator_ops tps65090_ext_control_ops = {
>> +};
> What is the purpose of adding empty structure?
>
We will not able to register regulator if there is no ops.
In regulator register:
if (regulator_desc->name == NULL || regulator_desc->ops == NULL)
return ERR_PTR(-EINVAL);
next prev parent reply other threads:[~2012-10-09 10:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 9:48 [PATCH V2 0/4] regulator: tps65090: fix regulator registration and add external control support Laxman Dewangan
2012-10-09 9:48 ` [PATCH V2 1/4] regulator; tps65090: Register all regulators in single probe call Laxman Dewangan
2012-10-09 9:49 ` [PATCH V2 2/4] regulator: tps65090: rename driver name and regulator name Laxman Dewangan
2012-10-09 9:49 ` [PATCH V2 3/4] regulator: tps65090: Add support for LDO regulators Laxman Dewangan
2012-10-09 9:49 ` [PATCH V2 4/4] regulator: tps65090: add external control support for DCDC Laxman Dewangan
2012-10-09 10:33 ` Venu Byravarasu
2012-10-09 10:02 ` Laxman Dewangan [this message]
2012-10-09 11:11 ` Venu Byravarasu
2012-10-09 11:13 ` Laxman Dewangan
2012-10-09 10:35 ` Mark Brown
2012-10-09 16:21 ` Stephen Warren
2012-10-17 13:21 ` [PATCH V2 0/4] regulator: tps65090: fix regulator registration and add external control support Mark Brown
2012-10-17 13:33 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5073F63B.9020606@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
--cc=vbyravarasu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.