From: Andreas Larsson <andreas@gaisler.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org, kernel@pengutronix.de, wg@grandegger.com
Subject: Re: [RFC: PATCH 1/5] can: sja1000_platform
Date: Tue, 09 Oct 2012 15:30:14 +0200 [thread overview]
Message-ID: <507426E6.7070605@gaisler.com> (raw)
In-Reply-To: <507299D4.9030506@gaisler.com>
On 10/08/2012 11:16 AM, Andreas Larsson wrote:
> On 10/05/2012 04:39 PM, Marc Kleine-Budde wrote:
>> Please test, especially on sparc, powerpc and arm.
>
> On sparc, sp_probe fails for me because there is no resource of type
> IORESOURCE_IRQ.
>
> As far as I can find out, on sparc (32 and 64 bit) IORESOURCE_IRQ
> resources are never created for the platform_device representation. The
> resources that are created are the ones created for adresses/registers
> in build_device_resources() in arch/sparc/kernel/of_device_32.c and
> arch/sparc/kernel/of_device_64.c respectively.
It is also worth mentioning that on sparc, the checks against the
different IORESOURCE_MEM_XXBIT will never be true due to the same
reason. This information is not in the platform_device representation on
sparc.
In my case I have 8-bit registers, so the default 8-bit saves me. With
the irq problem worked around, the driver works fine for me on sparc32.
Cheers,
Andreas
prev parent reply other threads:[~2012-10-09 13:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 14:39 [RFC: PATCH 1/5] can: sja1000_platform Marc Kleine-Budde
2012-10-05 14:39 ` [RFC: PATCH 1/5] can: sja1000_platform: add __dev{init,exit} annotations Marc Kleine-Budde
2012-10-05 14:39 ` [RFC: PATCH 2/5] can: sja1000_platform: convert ioremap_nocache to devm_request_and_ioremap Marc Kleine-Budde
2012-10-05 14:39 ` [RFC: PATCH 3/5] can: sja1000_platform: replace DRV_NAME by KBUILD_MODNAME Marc Kleine-Budde
2012-10-05 14:39 ` [RFC: PATCH 4/5] can: sja1000_platform: factor out initialization from platform data Marc Kleine-Budde
2012-10-05 14:39 ` [RFC: PATCH 5/5] can: sja1000_platform: add device tree bindings Marc Kleine-Budde
2012-10-05 15:47 ` Wolfgang Grandegger
2012-10-05 16:42 ` Marc Kleine-Budde
2012-10-05 16:58 ` Wolfgang Grandegger
2012-10-08 9:16 ` [RFC: PATCH 1/5] can: sja1000_platform Andreas Larsson
2012-10-08 12:19 ` Marc Kleine-Budde
2012-10-08 12:50 ` Andreas Larsson
2012-10-09 13:30 ` Andreas Larsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507426E6.7070605@gaisler.com \
--to=andreas@gaisler.com \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.