From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLbl6-0000QS-Ab for qemu-devel@nongnu.org; Tue, 09 Oct 2012 11:30:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLbkv-00063z-FS for qemu-devel@nongnu.org; Tue, 09 Oct 2012 11:30:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50053) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLbkv-00061w-54 for qemu-devel@nongnu.org; Tue, 09 Oct 2012 11:30:01 -0400 Message-ID: <50743CA0.2060000@redhat.com> Date: Tue, 09 Oct 2012 09:02:56 -0600 From: Eric Blake MIME-Version: 1.0 References: <1334778950-18660-1-git-send-email-ehabkost@redhat.com> <1334778950-18660-5-git-send-email-ehabkost@redhat.com> In-Reply-To: <1334778950-18660-5-git-send-email-ehabkost@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig9C7BD4B16D7828E28B3D9FEE" Subject: Re: [Qemu-devel] [PATCH 04/14] create_config: separate section for qemu_*dir variables (v2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Paolo Bonzini , qemu-devel@nongnu.org, Anthony Liguori This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig9C7BD4B16D7828E28B3D9FEE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/18/2012 01:55 PM, Eduardo Habkost wrote: > The generic *dir section will eventually go away and be replaced with > qemu_* section. By now, both sections will be kept, while the variables= > get renamed on config-host.mak. >=20 > With this patch, a XXXdir variable will become a CONFIG_QEMU_XXXDIR > define, and a qemu_XXXdir variable will become CONFIG_QEMU_XXXDIR as > well (instead of becoming a CONFIG_QEMU_QEMU_XXXDIR define). >=20 > Changes v1 -> v2: > - Rebase on top of newer qemu.git changes, that changed > "tr '[:lower:]' '[:upper:]'" to "LC_ALL=3DC tr '[a-z]' '[A-Z]'". >=20 > + qemu_*dir=3D*) # qemu-specific directory configuration > + name=3D${line%=3D*} Bug. You want ${line%%=3D*}, in case the value portion of this assignmen= t contains a second '=3D' character. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig9C7BD4B16D7828E28B3D9FEE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQdDyhAAoJEKeha0olJ0NqlckH/ibcvY/Oz5Ud5XBP4uzzCzSQ YwWQApGxbNbK5GNRbeLrahYcttID+8vorkxBzVnhdneynVn+PWF96Hqm/kQVkJjP TNxDZD3k0+VveIPs14P4kCkfllTD8id/b8MOfLjb34LGZ4GsBXdxycgrejh5EcOi YK4/Gjln5H5bHArAXz+C60HhX5z3DWGavYbOWMNWgZwCC+NvCJF8z4k+VVrkBZrZ YhJoOMc+c+v1Ze81uNM50o/2ug0uSODw2KF04+9UUUuC6SeiXRvIpR9e4IVKbnYC Uqyo03wLrCcY7bTizJKfyVhP5pxYNiOiUvgVqlcCFs0Ptyvg3VC4rKV3Ay3JCeo= =Omqk -----END PGP SIGNATURE----- --------------enig9C7BD4B16D7828E28B3D9FEE--