From: Alex Elder <elder@inktank.com>
To: ceph-devel@vger.kernel.org
Subject: [PATCH 2/2] libceph: mark ceph_msgr_wq unbounded
Date: Tue, 09 Oct 2012 14:29:46 -0700 [thread overview]
Message-ID: <5074974A.3010000@inktank.com> (raw)
In-Reply-To: <50749701.8010208@inktank.com>
Andreas Bluemle observed an undesirable behavior in the ceph
messenger when using networking hardware that binds received data
handling to a single CPU. The messenger uses a workqueue to process
message activity, and in this case all work was being queued on the
same per-cpu workqueue. Consequently that CPU becomes a bottleneck,
forced to process all incoming messages.
Marking the workqueue UNBOUND allows any available CPU to process a
work item on the queue. The concurrency of the workqueue will be
limited by the number of active connections.
Reported-by: Andreas Bluemle <andreas.bluemle@itxperts.de>
Signed-off-by: Alex Elder <elder@inktank.com>
---
net/ceph/messenger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c
index 28ed904..f9f65fe 100644
--- a/net/ceph/messenger.c
+++ b/net/ceph/messenger.c
@@ -190,7 +190,7 @@ int ceph_msgr_init(void)
zero_page = ZERO_PAGE(0);
page_cache_get(zero_page);
- ceph_msgr_wq = alloc_workqueue("ceph-msgr", 0, 0);
+ ceph_msgr_wq = alloc_workqueue("ceph-msgr", WQ_UNBOUND, 0);
if (ceph_msgr_wq)
return 0;
--
1.7.9.5
prev parent reply other threads:[~2012-10-09 21:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 21:28 [PATCH 0/2] libceph: workqueue changes Alex Elder
2012-10-09 21:29 ` [PATCH 1/2] libceph: mark ceph_msgr_wq reentrant Alex Elder
2012-10-09 21:29 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5074974A.3010000@inktank.com \
--to=elder@inktank.com \
--cc=ceph-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.