All of lore.kernel.org
 help / color / mirror / Atom feed
From: Valentine Barshak <gvaxon@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] linux: Fix initramfs compression
Date: Wed, 10 Oct 2012 02:44:44 +0400	[thread overview]
Message-ID: <5074A8DC.10705@gmail.com> (raw)
In-Reply-To: <5072841C.7010505@mind.be>

On 10/08/2012 11:43 AM, Arnout Vandecappelle wrote:
> On 07/10/12 22:22, Valentine Barshak wrote:
>> The problem here is that we can't set initramfs compression mode
>> unless the initramfs source (CONFIG_INITRAMFS_SOURCE)
>> is set. We can only set RAM disk compression modes that should be
>> supported by the kernel (CONFIR_RD_...).
>>
>> The source is set by buildroot. So the user has no capability to
>> configure compression explicitly, unless he (she) sets
>> a fake initramfs source file, which will be overridden by buildroot.
>> IMHO, this is a bit hackish way to set anything
>> other than default, which is COMPRESSION_NONE.
>>
>> Yes, that is what most people want. I just didn't want to drop other
>> options in case somebody wants a compressed
>> initramfs image.
>> This could be needed for systems with low memory, for example.
>
>   True.  Still, I don't think that this corner case warrants the additional
> complexity of grepping etc. in the buildroot makefile.  Especially
> because it
> still doesn't give the user complete configuration freedom: if both GZIP
> and
> BZIP2 initrd compression options are enabled (like is the case in some
> of the
> kernel's defconfigs), then still GZIP will be chosen.

Right.

>
>   If we really want to support this in buildroot, then the choice should
> be added
> to fs/initramfs/Config.in.  But also here I doubt that the (maintenance)
> work of
> having this option is worth it, because it's likely that it will _never_
> be used.
>
>   As you say yourself, if you really do need the option, there is a
> possibility
> to do it.  And it's not as bad as you say, because when you run
> 'make linux-menuconfig', buildroot will first run a 'linux-configure' so
> the
> INITRAMFS_SOURCE will already be set.  (At least, I think so :-)

Indeed, so it's probably better to let the kernel config handle it, 
instead of attempting to force any compression mode in BR.

>
>
>   Regards,
>   Arnout
>
Thanks,
Val.

      reply	other threads:[~2012-10-09 22:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-06 19:22 [Buildroot] [PATCH] linux: Fix initramfs compression Valentine Barshak
2012-10-07 11:31 ` Arnout Vandecappelle
2012-10-07 20:22   ` Valentine Barshak
2012-10-08  7:43     ` Arnout Vandecappelle
2012-10-09 22:44       ` Valentine Barshak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5074A8DC.10705@gmail.com \
    --to=gvaxon@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.